WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 6 months ago

#46849 closed defect (bug) (fixed)

Incorrect number of arguments to sprintf in wp-includes/ms-load.php

Reported by: diddledan Owned by: SergeyBiryukov
Milestone: 5.2 Priority: normal
Severity: normal Version: 4.4
Component: Networks and Sites Keywords: has-patch
Focuses: multisite Cc:
PR Number:

Description

The function ms_site_check() in wp-includes/ms-load.php will return a notification when a site is not activated yet with a link to email the multisite admin. This email is inserted into the notification text via sprintf, but is only passed once when the sprintf expects it twice. The attached patch fixes this for correctness.

Attachments (1)

46849.diff​ (1.1 KB) - added by diddledan 6 months ago.
patch to fix incorrect number of arguments to sprintf

Download all attachments as: .zip

Change History (4)

@diddledan
6 months ago

patch to fix incorrect number of arguments to sprintf

#1 @johnbillion
6 months ago

  • Component changed from General to Networks and Sites
  • Focuses multisite added
  • Milestone changed from Awaiting Review to 5.3
  • Version set to 4.4

Introduced in [35453].

#2 @SergeyBiryukov
6 months ago

  • Milestone changed from 5.3 to 5.2
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45162:

Networks and Sites: Use numbered placeholder in a mailto: link in ms_site_check().

Props diddledan.
Fixes #46849.

Note: See TracTickets for help on using tickets.