WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#46852 closed defect (bug) (fixed)

$_changeset_data has incorrect type annotation in docblock

Reported by: diddledani's profile diddledani Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: docs Cc:

Description

$_changeset_data in class WP_Customize_Manager defined in wp_includes/class-wp-customize-manager.php has type annotation in the docblock of array but the class occasionally assigns a null to this variable. The attached patch adds null to the type annotation in addition to the array already there.

Attachments (1)

46852.diff​ (920 bytes) - added by diddledani 7 years ago.
patch to change type annotation in docblock from array to array|null

Download all attachments as: .zip

Change History (5)

@diddledani
7 years ago

patch to change type annotation in docblock from array to array|null

#1 @SergeyBiryukov
7 years ago

  • Component changed from General to Customize
  • Focuses docs added

#2 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 5.3

#4 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45426:

Docs: Correct @type annotation for WP_Customize_Manager::$_changeset_data.

Props diddledan.
Fixes #46852.

Note: See TracTickets for help on using tickets.