WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#46854 closed defect (bug) (fixed)

Incorrect type docblock annotation for $current_partial_id in wp-includes/customize/class-wp-customize-selective-refresh.php

Reported by: diddledani Owned by: SergeyBiryukov
Priority: normal Milestone: 5.3
Component: Customize Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

The type annotation docblock indicates that $current_partial_id is a string, but occasionally the variable is assigned a null value. The attached patch fixes the docblock to state that null is allowable as well as string.

Attachments (1)

46854.diff​ (1.1 KB ) - added by diddledani 8 years ago.
patch to change type annotation in docblock from string to string|null

Download all attachments as: .zip

Change History (3)

@diddledani
8 years ago

patch to change type annotation in docblock from string to string|null

#1 @SergeyBiryukov
7 years ago

  • Component General → Customize
  • Focuses docs added
  • Milestone Awaiting Review → 5.3

Related: #46852, #46853.

#2 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 45428:

Docs: Correct @type annotation for WP_Customize_Selective_Refresh::$current_partial_id.

Props diddledan.
Fixes #46854.

Note: See TracTickets for help on using tickets.