WordPress.org

Make WordPress Core

Opened 5 months ago

Closed 4 months ago

#46856 closed defect (bug) (fixed)

Incorrect type docblock annotations for some variables in wp-includes/class-wp-customize-widgets.php

Reported by: diddledan Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: docs Cc:

Description

The type annotation for $context_sidebar_instance_number is set to int.
The type annotations for $rendering_widget_id and $rendering_sidebar_id are set to string.

Each of these are sometimes assigned null. The attached patch fixes their respective docblock type annotations to also include null.

Attachments (1)

46856.diff​ (1.7 KB) - added by diddledan 5 months ago.
patch to change type annotations in docblock for specific variables to also include null

Download all attachments as: .zip

Change History (3)

@diddledan
5 months ago

patch to change type annotations in docblock for specific variables to also include null

#1 @SergeyBiryukov
5 months ago

  • Component changed from General to Customize
  • Focuses docs added
  • Milestone changed from Awaiting Review to 5.3

Related: #46852-46854

#2 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45429:

Docs: Correct @type annotation for WP_Customize_Widgets properties.

Props diddledan.
Fixes #46856.

Note: See TracTickets for help on using tickets.