WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#46873 closed defect (bug) (fixed)

Some apostrophes are not HTML entities.

Reported by: tmatsuur Owned by: desrosj
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch site-health
Focuses: Cc:

Description

I am using version 5.2 Beta2.

Apostrophes are not HTML entities in some translated text of class-wp-site-health.php.

line: 630

_( 'PHP is the programming language we use to build and maintain WordPress. Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site’s performance.' )

line: 915

__( 'The SQL server is the database where WordPress stores all your site’s content and settings' )

Attachments (3)

46873.diff (1.3 KB) - added by subrataemfluence 2 years ago.
46873-2.diff (1.3 KB) - added by subrataemfluence 2 years ago.
Modified patch.
46873.3.diff (1.3 KB) - added by ianbelanger 2 years ago.
Refreshed patch

Download all attachments as: .zip

Change History (13)

#1 follow-up: @subrataemfluence
2 years ago

  • Keywords has-patch added

#2 in reply to: ↑ 1 @tmatsuur
2 years ago

Replying to subrataemfluence:

Thanks.

#3 @SergeyBiryukov
2 years ago

  • Keywords site-health added
  • Milestone changed from Awaiting Review to 5.2

#4 @SergeyBiryukov
2 years ago

Hi @subrataemfluence, thanks for the patch!

Instead of plain apostrophes, we should use the ’ entity here, for consistency with the rest of the strings.

#5 @subrataemfluence
2 years ago

Thank you @SergeyBiryukov. I will work on it and upload today.

@subrataemfluence
2 years ago

Modified patch.

#6 @subrataemfluence
2 years ago

Please let me know if the patch looks OK now.

#7 @desrosj
2 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#8 @ianbelanger
2 years ago

The patch did not apply cleanly for me so I am uploading a refreshed patch.

@ianbelanger
2 years ago

Refreshed patch

#9 @desrosj
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

I accidentally included 46873.3.diff with [45170].

Props to @tmatsuur, @ianbelanger, and @subrataemfluence.

#10 @spacedmonkey
2 years ago

  • Component changed from I18N to Site Health
Note: See TracTickets for help on using tickets.