WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#46875 closed defect (bug) (fixed)

ALT Text description should be added to media.php edit page too.

Reported by: chetan200891's profile chetan200891 Owned by: afercia's profile afercia
Milestone: 5.2 Priority: normal
Severity: normal Version: 5.2
Component: Media Keywords: has-patch commit
Focuses: accessibility, administration Cc:

Description

After reviewing ticket #41612, I found that ALT Text description is added to Media edit model, New Media model but it is missing on media edit page, when someone edit media from media list view.

Attachments (2)

46875.diff​ (1.0 KB) - added by chetan200891 6 years ago.
Created initial patch to add ALT Text description to media edit page.
46875.2.diff​ (3.2 KB) - added by afercia 6 years ago.

Download all attachments as: .zip

Change History (7)

@chetan200891
6 years ago

Created initial patch to add ALT Text description to media edit page.

This ticket was mentioned in ​Slack in #accessibility by chetan200891. ​View the logs.
6 years ago

#2 @chetan200891
6 years ago

  • Keywords has-patch added; needs-patch removed

#3 @afercia
6 years ago

  • Component changed from General to Media
  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.2
  • Owner set to afercia
  • Status changed from new to assigned
  • Version set to trunk

Thanks @chetan200891! This was missed in [44900] which is landing in WordPress 5.2.

As it's a simple, self-contained change, and brings parity with the changes introduced in [44900], I'd like to propose to move it to 5.2 consideration.

@afercia
6 years ago

#4 @afercia
6 years ago

  • Keywords commit added; needs-refresh removed

46875.2.diff​ builds on the previous patch and:

  • places the alt text field as first field, as done in [44900]
  • adds aria-describedby
  • adjusts the CSS
  • since I was there... fixes a weird indentation after [42343]

#5 @afercia
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45158:

Accessibility: Improve the image "Alternative Text" field in the Edit Media screen.

Brings parity with the changes for the Media Views introduced in [44900].

  • moves the alt text field to the top as first field
  • adds an explanatory text with a link pointing to the W3C "alt decision tree" tutorial
  • adds aria-describedby to target the explanatory text
  • adjusts the CSS and indentation

Props chetan200891.
Fixes #46875.

Note: See TracTickets for help on using tickets.