WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46886, comment 2


Ignore:
Timestamp:
04/12/2019 10:14:53 PM (7 years ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #46886, comment 2

    initial v1  
    88
    99it seems to allow the {{{target}}} attribute to be part of another string, thus picking up {{{data-target}}} as a false positive.
     10
     11But at the moment it seems tempting to just replace:
     12
     13{{{stripos( $text, 'target' ) !== false}}}
     14
     15with:
     16
     17{{{stripos( $text, ' target' ) !== false }}}
     18
     19within {{{wp_targeted_link_rel()}}} here:
     20
     21https://core.trac.wordpress.org/browser/tags/5.1.1/src/wp-includes/formatting.php#L3040
     22
     23At least the unit tests in {{{Tests_Targeted_Link_Rel}}} seems to like it :-)
     24