WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46901, comment 20


Ignore:
Timestamp:
04/26/2019 01:30:55 PM (21 months ago)
Author:
afercia
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46901, comment 20

    initial v1  
    11> The tabs look strange on the small screen
    22
    3 Oh yes, I see now there's a difference compared to 5.1.1. This comes in part from the markup change in [44905] / #43398 and in part from the various changes to the `line-height` values in core to make them unit-less. The point is, when using line-height unit-less value and then the font-size changes in the responsive view, the line-height computer value won't be the expected one. It needs to be set again with a proper value based on the responsive font-size. /Cc @ianbelanger
     3Oh yes, I see now there's a difference compared to 5.1.1. This comes in part from the markup change in [44905] / #43398 and in part from the various changes to the `line-height` values in core to make them unit-less. The point is, when using line-height unit-less value and then the font-size changes in the responsive view, the line-height computed value won't be the expected one. It needs to be set again with a proper value based on the responsive font-size. /Cc @ianbelanger
    44
    55Patch incoming.