WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #46901, comment 37


Ignore:
Timestamp:
05/01/2019 06:36:33 AM (2 years ago)
Author:
kjellr
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46901, comment 37

    initial v1  
    11Just a minor heads up in case someone ends up having some time for this: Ideally, the Health Check and Error Protection `feature-section`s would be using our `two-col` class, and the text inside them would be aligned vertically using the flexbox styles for columns that are in the stylesheet.
    22
    3 If someone were to take that on, it's worth noting that for now, the columns in those sections are not inheriting our columns styles at all. This is because these styles because the columns style rule is written to specify `[class$="-col"]`. This looks for a class attribute that ends in `-col`. That means the  order of the classnames in the HTML attribute matters if we want that style to be picked up. The Health Check and Error Protection sections have four total classnames, and their current `one-col` class is sandwiched in between the others. If we want to have the columns style rules kick in, we'd first need to rearrange the class declarations so that the `-col` is at the end. 👍
     3If someone were to take that on, it's worth noting that for now, the columns in those sections are not inheriting our columns styles at all. This is because the columns style rule uses `[class$="-col"]` (it looks for a class attribute that ends in `-col`). That means the  order of the classnames in the HTML attribute matters if we want that style to be picked up. The Health Check and Error Protection sections have four total classnames, and their current `one-col` class is sandwiched in between the others. If we want to have the columns style rules kick in, we'd first need to rearrange the class declarations so that the `-col` is at the end. 👍