WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

#46928 closed defect (bug) (fixed)

Docs: Add missing description for global $comment param

Reported by: immeet94's profile immeet94 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch commit
Focuses: docs Cc:

Description


Attachments (2)

#46928.diff​ (1.5 KB) - added by immeet94 6 years ago.
Please see this file for patch
#46928-2.diff​ (3.4 KB) - added by immeet94 6 years ago.
upload patch file

Download all attachments as: .zip

Change History (10)

@immeet94
6 years ago

Please see this file for patch

#1 @mukesh27
6 years ago

  • Focuses coding-standards removed
  • Keywords needs-refresh added

Hi @immeet94, thanks for the patch!

It would be good to perform global search for @global WP_Comment and then add description for $comment in DocBlocks.

Need to add/replace description in below files.

  • wp-includes/class-wp-query.ph
  • wp-includes/comment-template.ph
  • wp-includes/comment.ph
  • wp-includes/template.php

#2 @immeet94
6 years ago

Hi @mukesh27 , Thanks for guiding me

just update the patch.

Thanks.

@immeet94
6 years ago

upload patch file

#3 @mukesh27
6 years ago

  • Keywords needs-refresh removed

#46928-2.diff​ looks good to me.

#4 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.3

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
5 years ago

#6 @davidbaumwald
5 years ago

  • Keywords commit added

#7 @SergeyBiryukov
5 years ago

  • Component changed from General to Comments

Related: #46503

#8 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46391:

Docs: Add missing description for $comment global.

Props immeet94, mukesh27.
Fixes #46928. See #47110.

Note: See TracTickets for help on using tickets.