WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 6 months ago

#46931 new defect (bug)

Argument type mismatch

Reported by: subrataemfluence Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Comments Keywords: has-patch
Focuses: docs Cc:
PR Number:

Description

In wp-includes/comment-template.php, we have argument types mismatched in DOC block of comment_form_title function.

Please check if the proposed patch works.

Attachments (4)

46931.diff (1.5 KB) - added by subrataemfluence 6 months ago.
46931-2.diff (4.6 KB) - added by subrataemfluence 6 months ago.
error.png (268.2 KB) - added by mukesh27 6 months ago.
46931-3.diff (4.6 KB) - added by subrataemfluence 6 months ago.

Download all attachments as: .zip

Change History (10)

#1 @mukesh27
6 months ago

  • Keywords needs-refresh added

Hi @subrataemfluence, thanks for the patch!

Can you please check other function in wp-includes/comment-template.php and fix similar DocBlocks.

Like below function that need to fix, If required check other functions and fix similar DocBlocks.

comments_number
get_comments_number_text
comment_type

#2 @subrataemfluence
6 months ago

@mukesh27 I am actually looking through the file! :)

#3 @mukesh27
6 months ago

@subrataemfluence There is small error in patch 46931-2.diff line number 888

@mukesh27
6 months ago

#4 @subrataemfluence
6 months ago

Strange! I can't see it at my end!! How come it gets in there? Anyways, I have submitting again. The patch is still the same :)

#5 follow-up: @mukesh27
6 months ago

  • Keywords needs-refresh removed

46931-3.diff​ looks good to me.

#6 in reply to: ↑ 5 @subrataemfluence
6 months ago

Thanks!

Replying to mukesh27:

46931-3.diff​ looks good to me.

Note: See TracTickets for help on using tickets.