Site Health: Pseudo dashicons for list should be vertically centered

[chetan200891]

On Site Health page there are different dashicons added based on status on list. One of them is vertically top and other are not. All of them should be vertically centered.

[desrosj]

@chetan200891 Looking at the Dashicons CSS file in core, it looks like the icons are assigned vertical-align: top there. Attaching a screenshot of all the icons aligned top for comparison.

Also, it may be worth exploring using actual Dashicon classes in addition to .fail, .info, etc. classes. There is also a lot of repetition within these CSS definitions. The display, vertical-align and font-family properties can be consolidated.

[chetan200891]

Updated patch.

[chetan200891]

@desrosj Thanks for your suggestion. I have now updated patch 46940.1.diff based on your suggestion. Added dashicons class.

[Clorith]

This looks much cleaner already, tried out 46940.1.diff​ and I say we roll with that.

[desrosj]

In 45309:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

[desrosj]

Reopening for backport consideration.

[desrosj]

In 45314:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.