WordPress.org

Make WordPress Core

Opened 6 weeks ago

Closed 11 days ago

#46940 closed defect (bug) (fixed)

Site Health: Pseudo dashicons for list should be vertically centered

Reported by: chetan200891 Owned by: desrosj
Milestone: 5.2.1 Priority: normal
Severity: normal Version: 5.2
Component: Administration Keywords: has-patch has-screenshots site-health fixed-major
Focuses: ui, administration Cc:

Description

On Site Health page there are different dashicons added based on status on list. One of them is vertically top and other are not. All of them should be vertically centered.

Attachments (7)

46940.diff (837 bytes) - added by chetan200891 6 weeks ago.
before patch.png (44.1 KB) - added by desrosj 6 weeks ago.
after patch.png (44.1 KB) - added by desrosj 6 weeks ago.
vertical-align top.png (44.0 KB) - added by desrosj 6 weeks ago.
46940.1.diff (1.8 KB) - added by chetan200891 6 weeks ago.
Updated patch.
after-udpated-patch-screenshot-1.png (38.6 KB) - added by chetan200891 6 weeks ago.
after-udpated-patch-screenshot-2.png (30.6 KB) - added by chetan200891 6 weeks ago.

Download all attachments as: .zip

Change History (20)

@chetan200891
6 weeks ago

#1 @chetan200891
6 weeks ago

  • Focuses ui administration added
  • Keywords has-patch added

#2 @SergeyBiryukov
6 weeks ago

  • Component changed from General to Administration

@desrosj
6 weeks ago

@desrosj
6 weeks ago

#3 @chetan200891
6 weeks ago

  • Keywords has-screenshots needs-design-feedback added

#4 @desrosj
6 weeks ago

  • Keywords needs-design-feedback removed

@chetan200891 Looking at the Dashicons CSS file in core, it looks like the icons are assigned vertical-align: top there. Attaching a screenshot of all the icons aligned top for comparison.

Also, it may be worth exploring using actual Dashicon classes in addition to .fail, .info, etc. classes. There is also a lot of repetition within these CSS definitions. The display, vertical-align and font-family properties can be consolidated.

#5 @desrosj
6 weeks ago

  • Milestone changed from Awaiting Review to 5.2.1
  • Version set to trunk

@chetan200891
6 weeks ago

Updated patch.

#6 @chetan200891
6 weeks ago

@desrosj Thanks for your suggestion. I have now updated patch 46940.1.diff based on your suggestion. Added dashicons class.

#7 @earnjam
4 weeks ago

  • Keywords site-health added

#8 @Clorith
2 weeks ago

  • Keywords commit added

This looks much cleaner already, tried out 46940.1.diff and I say we roll with that.

#9 @desrosj
11 days ago

  • Owner set to desrosj
  • Status changed from new to assigned

#10 @desrosj
11 days ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45309:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

#11 @desrosj
11 days ago

  • Keywords fixed-major added; commit removed

Reopening for backport consideration.

#12 @desrosj
11 days ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#13 @desrosj
11 days ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45314:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

Note: See TracTickets for help on using tickets.