WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 9 months ago

Last modified 8 months ago

#46940 closed defect (bug) (fixed)

Site Health: Pseudo dashicons for list should be vertically centered

Reported by: chetan200891 Owned by: desrosj
Milestone: 5.2.1 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch has-screenshots site-health fixed-major
Focuses: ui, administration Cc:
PR Number:

Description

On Site Health page there are different dashicons added based on status on list. One of them is vertically top and other are not. All of them should be vertically centered.

Attachments (7)

46940.diff (837 bytes) - added by chetan200891 10 months ago.
before patch.png (44.1 KB) - added by desrosj 10 months ago.
after patch.png (44.1 KB) - added by desrosj 10 months ago.
vertical-align top.png (44.0 KB) - added by desrosj 10 months ago.
46940.1.diff (1.8 KB) - added by chetan200891 10 months ago.
Updated patch.
after-udpated-patch-screenshot-1.png (38.6 KB) - added by chetan200891 10 months ago.
after-udpated-patch-screenshot-2.png (30.6 KB) - added by chetan200891 10 months ago.

Download all attachments as: .zip

Change History (21)

@chetan200891
10 months ago

#1 @chetan200891
10 months ago

  • Focuses ui administration added
  • Keywords has-patch added

#2 @SergeyBiryukov
10 months ago

  • Component changed from General to Administration

@desrosj
10 months ago

#3 @chetan200891
10 months ago

  • Keywords has-screenshots needs-design-feedback added

#4 @desrosj
10 months ago

  • Keywords needs-design-feedback removed

@chetan200891 Looking at the Dashicons CSS file in core, it looks like the icons are assigned vertical-align: top there. Attaching a screenshot of all the icons aligned top for comparison.

Also, it may be worth exploring using actual Dashicon classes in addition to .fail, .info, etc. classes. There is also a lot of repetition within these CSS definitions. The display, vertical-align and font-family properties can be consolidated.

#5 @desrosj
10 months ago

  • Milestone changed from Awaiting Review to 5.2.1
  • Version set to trunk

@chetan200891
10 months ago

Updated patch.

#6 @chetan200891
10 months ago

@desrosj Thanks for your suggestion. I have now updated patch 46940.1.diff based on your suggestion. Added dashicons class.

#7 @earnjam
10 months ago

  • Keywords site-health added

#8 @Clorith
9 months ago

  • Keywords commit added

This looks much cleaner already, tried out 46940.1.diff and I say we roll with that.

#9 @desrosj
9 months ago

  • Owner set to desrosj
  • Status changed from new to assigned

#10 @desrosj
9 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45309:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

#11 @desrosj
9 months ago

  • Keywords fixed-major added; commit removed

Reopening for backport consideration.

#12 @desrosj
9 months ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#13 @desrosj
9 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45314:

Site Health: Improve vertical alignment of icons in test result descriptions.

This change removes redundant CSS properties for different health check statuses in favor of utilizing the .dashicons class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.

#14 @spacedmonkey
8 months ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.