WordPress.org

Make WordPress Core

Opened 8 days ago

Last modified 7 days ago

#46946 new enhancement

Site Health: Text adjustment (add a link and remove "we")

Reported by: birgire Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: trunk
Component: Text Changes Keywords: site-health has-patch
Focuses: Cc:

Description

It would be helpful, I think, to have a link to the Site Health Status page within this text:

"If we see anything here that could be improved, we will let you know on the Site Health Status page."

on the /wp-admin/site-health.php?tab=debug page.

Additionally it could be adjusted further to avoid the "We" self-reference, as suggested in #46057.

Also "anything here" is too general, in my mind.

cheers

Attachments (3)

46946.diff (993 bytes) - added by mukesh27 8 days ago.
Updated text.
46946-2.diff (1.0 KB) - added by subrataemfluence 7 days ago.
Added suggested link against text "Site Health Status page".
46946-3.diff (1.0 KB) - added by subrataemfluence 7 days ago.
Updated patch. I also excluded the word "page" from the link as per the original ticket description.

Download all attachments as: .zip

Change History (9)

#1 @Clorith
8 days ago

  • Milestone changed from Awaiting Review to 5.3

Good points, the string here could be improved upon to be more useful.

I've marked it for 5.3, so we can improve on it for the next release, as we're past the string freeze for the current release cycle.

@mukesh27
8 days ago

Updated text.

#2 @mukesh27
8 days ago

  • Keywords has-patch added

@birgire and @Clorith Please suggest text if needed.

@subrataemfluence
7 days ago

Added suggested link against text "Site Health Status page".

#3 @subrataemfluence
7 days ago

@mukesh27 I have added the suggested link. Also a related thought (since the text link was suggested). As the page can turn into a long one when all or some sections are expanded, how about adding the same link at the bottom of the page?

#4 follow-up: @birgire
7 days ago

Thanks @mukesh27 and @subrataemfluence for the patches.

In 46946.diff does the part:

If any improvement needed then it will show on the ...

need an "is" after the "improvement" ? (I'm not a native English speaker).

Regarding the link in In 46946-2.diff, I would suggest using:

esc_url( admin_url( 'site-health.php' ) )

instead of

esc_url( admin_url()  . 'site-health.php' )

to e.g. make the path accessible in the admin_url filter.

Also a related thought (since the text link was suggested). As the page can turn into a long one when all or some sections are expanded, how about adding the same link at the bottom of the page?

Thanks for the suggestion on @subrataemfluence. Maybe this consideration would be better focused in a possible new ticket? I guess other admin pages will reuse this design in the future. How to help navigate long pages, in this new design, is a good question.

Last edited 7 days ago by birgire (previous) (diff)

@subrataemfluence
7 days ago

Updated patch. I also excluded the word "page" from the link as per the original ticket description.

#5 in reply to: ↑ 4 @subrataemfluence
7 days ago

Thank you @birgire. As per your advice I have created a new ticket #46956 with the following enhancement request.

Related #46956.

Thanks for the suggestion on @subrataemfluence. Maybe this consideration would be better focused in a possible new ticket? I guess other admin pages will reuse this design in the future. How to help navigate long pages, in this new design, is a good question.

#6 @mukesh27
7 days ago

Patch 46946-3.diff looks good for me

Note: See TracTickets for help on using tickets.