Which of 'privacypolicy' or 'privacy_policy' is valid for get_query_template function?

[tmatsuur]

Currently, 'privacy_policy' is used in the get_privacy_policy_template function.

return get_query_template( 'privacy_policy', $templates );

In contrast, the docs contains a 'privacypolicy' without the hyphen.

Is the content of docs wrong?

[tmatsuur]

It was an underscore, not a hyphen.

[johnbillion]

This sounds like the same problem that happens with front_page.

[tmatsuur]

Replying to johnbillion:

This sounds like the same problem that happens with front_page.

Thank you @johnbillion.

[johnbillion]

This template was introduced in #44005.

Related issue for the underscore being stripped out: #21213.

Let's standardise on using either privacypolicy or privacy.

[SergeyBiryukov]

In 45231:

Themes: Standardize on passing frontpage and privacypolicy as the $type parameter to get_query_template().

These keys are used in {$type}_template_hierarchy and {$type}_template filters.

Previously, front_page and privacy_policy were passed, but get_query_template() stripped the underscores before passing the values to the filters.

Props rinatkhaziev, tmatsuur, johnbillion.
Fixes #21213, #46958.

[garrett-eclipse]

Thanks for catching this @tmatsuur and identifying the issue @johnbillion I'd copied the front_page implementation for #44005 and overlooked there was a pre-existing issue with that.
I appreciate the quick turnaround and patch @SergeyBiryukov
All the best