#46959 closed defect (bug) (invalid)
Missing translators in inline Doc
Reported by: | subrataemfluence | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Site Health | Keywords: | site-health has-patch |
Focuses: | docs | Cc: |
Description
Following placeholders are missing translators
in wp-admin/site-health-info.php
printf( '(%d)', count( $details['fields'] ) );
printf( '<p>%s</p>', wp_kses( $details['description'], $kses_settings ) );
$values .= sprintf( '<li>%s: %s</li>', esc_html( $name ), esc_html( $value ) );
printf( '<tr><td>%s</td><td class="%s">%s</td></tr>', esc_html( $field['label'] ), esc_attr( $field_name ), $values );
printf( '<tr><td>%s</td><td>%s</td></tr>', esc_html( $field['label'] ), $values );
I have uploaded a possible fix. Please check if this worth!
Attachments (1)
Change History (6)
#3
@
5 years ago
- Milestone Awaiting Review deleted
- Resolution set to invalid
- Status changed from new to closed
As @tobifjellner mentioned, there are no translation strings here that need comments, we're using sprintf
(which is often used alongside translation functions such as __()
, so I can understand the confusion here) to combine strings in a way that's easy to read.
Hmm. You've added comments for translators where there are no translatable strings...
Strings for translation will be wrapped in such functions, as
__()
,_n()
,_e()
, etc.