WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #46964, comment 30


Ignore:
Timestamp:
02/09/2020 11:16:05 PM (22 months ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #46964, comment 30

    v2 v3  
    3838I think the best solution here would be to reconsider [https://github.com/WordPress/gutenberg/pull/4697 PR4697] on the Gutenberg side, which tried to address the issue, but gave `#poststuff` too broad a scope, resulting in [https://github.com/WordPress/gutenberg/pull/4697#issuecomment-364117969 CSS bleed] and eventual revert in [https://github.com/WordPress/gutenberg/pull/4971 PR4971]. If `#poststuff` is just moved outside of the loop and `#postbox-container-2` is removed from `the_block_editor_meta_boxes()`, that would resolve duplicate IDs without any back-compat issues.
    3939
    40 If we're fine with a potential breaking change for 5200+ plugins, I suggest we go the distance and convert the remaining `#postbox-container-*` IDs to classes to avoid issues like this in the future. See [attachment:"46964.2.diff"].
     40If we're fine with a potentially breaking change for 5200+ plugins, I suggest we go the distance and convert the remaining `#postbox-container-*` IDs to classes to avoid issues like this in the future. See [attachment:"46964.2.diff"].