Theme update links show in Customizer and don't work

[desrosj]

When using the Customizer on a multisite install and browsing themes, a link to update shows but produces a JavaScript error when clicked.

TypeError: wp.updates is undefined

Installing themes for multisite was officially disabled in [38887]. An update notice shows on the Theme Details view but the link is omitted. The same approach should be used here.

Looks like the thumbnail preview checks that there is an update, but not for the presence of update information, so the link always shows.

[earnjam]

46997.diff​ gets rid of the Update Now link on single site too when viewing all of the themes in the Customizer in thumbnail view. See screenshot above

[desrosj]

Going to punt this one so it can get a refresh and more testing.

[mukesh27]

@desrosj, As tested by @earnjam i got same error for 46997.diff patch.

data.update variable does not got any value for single installation or in multisite installation.

Instead of that can we check if current site is multisite or not in /wp-includes/customize/class-wp-customize-theme-control.php then it will resolve above issue for me.

Check below attached patch.

[mukesh27]

Updated patch.

[audrasjb]

@desrosj @earnjam
46997.2.diff looks good on my side. Could we expect a peer review (we need two committers since we are in RC workflow) for tomorrow so this ticket coul ship with 5.2.2 RC2?

[garrett-eclipse]

Minor Refresh to convert printf to multi-line function and moved translator comments inside.

[garrett-eclipse]

Reviewing I made a minor refresh in 46997.3.diff to make the printf a multi-line function and moved it's translator comment inside

[earnjam]

Small CS fix for 46997.3.diff

[earnjam]

Looks like the later patches solved the issue of still allowing updating theme from the customizer in single site. In 46997.4.diff​ I just made a small CS fix to 46997.3.diff​.

I think this is ready to go, but I'm not a committer, so we need @desrosj and one more to sign off on it.

[desrosj]

This looks good! Going to commit this to trunk now.

Marking dev-feedback for a second review before backporting.

[azaozz]

46997.4.diff looks good here.

[desrosj]

In 45527:

Customize: Remove “Update” link for themes on multisite installs.

In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.

This removes that update link because updates cannot actually be performed in the Customizer in this situation.

Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997.

[desrosj]

Thanks, @azaozz! Reopening for backporting to 5.2.

[desrosj]

In 45528:

Customize: Remove “Update” link for themes on multisite installs.

In [38887], installing themes in the Customizer was disabled for multisite installs. However, an update link continues to be displayed when a theme update is available. Clicking the link causes a JavaScript error.

This removes that update link because updates cannot actually be performed in the Customizer in this situation.

Reviewed by desrosj and azaozz.
Merges [45527] to the 5.2 branch.

Props desrosj, earnjam, mukesh27, audrasjb, garrett-eclipse.
Fixes #46997.