WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 14 months ago

Last modified 14 months ago

#47016 closed defect (bug) (fixed)

Tabs on smaller device has no white space between rows

Reported by: subrataemfluence Owned by:
Milestone: 5.2 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch
Focuses: ui, administration Cc:

Description

When looking at /wp-admin/about.php, /wp-admin/credits.php, /wp-admin/freedoms.php and /wp-admin/freedoms.php?privacy-notice on smaller devices the tabs are broken into two lines but there is no white space between the lines, i.e. the tabs are stuck vertically with each other.

Also, since the horizontal continuous line is not visible in smaller devices it is good to have the bottom border added to each tab.

Screenshots attached.

Attachments (5)

no-white-space-between-tab-rows.png (47.6 KB) - added by subrataemfluence 18 months ago.
Current view of the page in mobile device
after-applying-patch.png (48.0 KB) - added by subrataemfluence 18 months ago.
View of he page after applying patch
47016.diff (620 bytes) - added by subrataemfluence 18 months ago.
Proposed patch.
47015.2.diff (618 bytes) - added by subrataemfluence 18 months ago.
Modified patch to use max-width: 600px since the horizontal line under tabs starts at 601px.
47016.2.diff (618 bytes) - added by subrataemfluence 18 months ago.
Please ignore 47015.2.diff. It had to be 47016.2.diff. Uploading the right one. Sorry for the confusion.

Download all attachments as: .zip

Change History (12)

@subrataemfluence
18 months ago

Current view of the page in mobile device

@subrataemfluence
18 months ago

View of he page after applying patch

@subrataemfluence
18 months ago

Proposed patch.

#1 @subrataemfluence
18 months ago

  • Keywords has-patch added; needs-patch removed

@subrataemfluence
18 months ago

Modified patch to use max-width: 600px since the horizontal line under tabs starts at 601px.

@subrataemfluence
18 months ago

Please ignore 47015.2.diff. It had to be 47016.2.diff. Uploading the right one. Sorry for the confusion.

#2 @SergeyBiryukov
18 months ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 5.3

This ticket was mentioned in Slack in #core by sergey. View the logs.


18 months ago

#4 @afercia
18 months ago

Related: #46901.

Worth noting this happens only on trunk and was introduced by the changes in [44905] / #43398 and [45243] / #46493.

I've uploaded a patch there to restore the original tabs spacing and size for smaller screens, see https://core.trac.wordpress.org/attachment/ticket/46901/46901-tabs.diff

See related comment https://core.trac.wordpress.org/ticket/46901#comment:20

This ticket was mentioned in Slack in #core by david.baumwald. View the logs.


14 months ago

#6 @afercia
14 months ago

  • Milestone 5.3 deleted
  • Resolution set to fixed
  • Status changed from new to closed

This issue was fixed in [45276] / #46901.

#7 @SergeyBiryukov
14 months ago

  • Milestone set to 5.2
Note: See TracTickets for help on using tickets.