WordPress.org

Make WordPress Core

Opened 5 months ago

Last modified 2 weeks ago

#47019 reviewing defect (bug)

Twenty Sixteen: Text color setting in pullquote block not applied

Reported by: kokkieh Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: good-first-bug needs-testing has-patch
Focuses: Cc:

Description

Text color settings in the pull quote block are not being applied.

To replicate:

  1. With Twenty Sixteen active, create a new post in the block editor
  2. Add a Pullquote block
  3. Add some text and try adjusting the color settings

Result:

The border color is applied, but the text color is not applied in either the editor or the published post.

The source code for the post does show a class for the applied color:

<figure class="wp-block-pullquote" style="border-color:#ff675f"><blockquote class="has-text-color has-bright-blue-color"><p>This is a quote</p><cite>by me<br></cite></blockquote></figure>

But looking in the inspector it seems the color is instead being applied from the blocks.css file, line 170:

.wp-block-pullquote p {
	color: #686868;
	font-size: 19px;
	font-size: 1.1875rem;
}

Reported by a WordPress.com user in the forums, but confirmed on a self-hosted installation as well. Also tested with no plugins active at all to rule out possible conflicts.

Attachments (2)

47019.diff (1.0 KB) - added by mukesh27 5 months ago.
Patch.
47019.2.diff (470 bytes) - added by khushbu19 4 months ago.

Download all attachments as: .zip

Change History (12)

#1 @desrosj
5 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.3
  • Version changed from 5.1.1 to 5.0

Thanks, @kokkieh! I am also able to reproduce this. Looks like the text color has never worked correctly in Twenty Sixeteen.

@mukesh27
5 months ago

Patch.

#2 @mukesh27
5 months ago

  • Keywords needs-testing added

#3 @mukesh27
5 months ago

  • Keywords has-patch added; needs-patch removed

@khushbu19
4 months ago

#4 @disillusia
4 months ago

  • Keywords 2nd-opinion added

Hello guys!

Tested both 47019 and 47019.2.

47019 looks good to me; it seems to solve the issue on both the editor and frontend. On the other hand, 47019.2 doesn't seem to work well.

First time participating/contributing so I hope I'm doing it correctly! Looking forward to help out more.

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 months ago

#6 @aliveic
4 months ago

Hi all.

I also tested the 47019 patch and I confirm that it works on my freshly installed latest build.

This is my first contribution. Hope it's helpful.

This ticket was mentioned in Slack in #core by desrosj. View the logs.


3 months ago

#8 @desrosj
3 months ago

  • Keywords 2nd-opinion removed

#9 @SergeyBiryukov
3 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#10 @abrightclearweb
2 weeks ago

47019 works for me too.

Note: See TracTickets for help on using tickets.