Twenty Sixteen: Text color setting in pullquote block not applied

[kokkieh]

Text color settings in the pull quote block are not being applied.

To replicate:

1. With Twenty Sixteen active, create a new post in the block editor
2. Add a Pullquote block
3. Add some text and try adjusting the color settings

Result:

The border color is applied, but the text color is not applied in either the editor or the published post.

The source code for the post does show a class for the applied color:

<figure class="wp-block-pullquote" style="border-color:#ff675f"><blockquote class="has-text-color has-bright-blue-color"><p>This is a quote</p><cite>by me<br></cite></blockquote></figure>

But looking in the inspector it seems the color is instead being applied from the blocks.css file, line 170:

.wp-block-pullquote p {
	color: #686868;
	font-size: 19px;
	font-size: 1.1875rem;
}

Reported by a WordPress.com user in the ​forums, but confirmed on a self-hosted installation as well. Also tested with no plugins active at all to rule out possible conflicts.

[desrosj]

Thanks, @kokkieh! I am also able to reproduce this. Looks like the text color has never worked correctly in Twenty Sixeteen.

[mukesh27]

Patch.

[disillusia]

Hello guys!

Tested both 47019 and 47019.2.

47019 looks good to me; it seems to solve the issue on both the editor and frontend. On the other hand, 47019.2 doesn't seem to work well.

First time participating/contributing so I hope I'm doing it correctly! Looking forward to help out more.

[aliveic]

Hi all.

I also tested the 47019 patch and I confirm that it works on my freshly installed latest build.

This is my first contribution. Hope it's helpful.

[abrightclearweb]

47019 works for me too.

[davidbaumwald]

The most recent patch applies cleanly to trunk, and the testing appears to confirm a resolution. Marking this one for commit.

[SergeyBiryukov]

I might be doing something wrong, but for some reason 47019.diff​ did not resolve the issue in my testing. I did, however, notice that other bundled themes appear to have the same issue.

Moving to 5.4 to handle this consistently across all bundled themes.

[ianbelanger]

Updates patch with with style fix for pullquote, border-left was not showing on front end

[ianbelanger]

Reviewing for commit.

[ianbelanger]

In 47273:

Bundled Themes: Twenty Sixteen text color setting in pullquote block not applied.

Fixes the pullquote color setting by moving color from blockquote p to blockquote. Also adds the border-left to the front-end stylesheet to match the editor. Also adds styles for rtl pullquote.

Props kokkieh, desrosj, mukesh27, khushbu19, disillusia, aliveic, abrightclearweb, SergeyBiryukov.
Fixes #47019.

[ianbelanger]

Reopening for backport.

[audrasjb]

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.
Please don't move them back to 5.3.3 :-)