Fatal error when making child category

[Viper007Bond]

Go to Manage -> Categories and try to make a new category that's the child of another category. Doing so will produce the following error:

Catchable fatal error: Object of class stdClass could not be converted to string in [...]\wp-includes\taxonomy.php on line 765

Editing a category and turning it into the child of another also causes this issue.

Props to Ryan Fitzer for finding the issue.

[Viper007Bond]

PHP v5.2.1, MySQL v5.0.37

[markjaquith]

I get:

Catchable fatal error: Object of class stdClass could not be converted to string in [...]/wp-includes/taxonomy.php on line 647

Both lines are $wpdb->query() calls.

[markjaquith]

Accept $parent as object or int

[markjaquith]

There's my swing at it... but I don't know if the error is that these functions don't accept term objects as well as ints or if the error is that these functions are being passed parent term objects. I opted for the more liberal case and accepted either. Would like to get Ryan's feedback on this one as this is his code.

[ryan]

Let me look through the code, I don't remember intending it to take objects.

[ryan]

The call to get_category in wp_insert_category take the category ID as a ref. It then assigns the retrieved object to it, thus changing the id to an object. That ref is pretty useless. Let's remove it. Also, category_exists would be a better way to check the cat.

[ryan]

(In [5938]) Don't pass cat as ref. Fix some term sanitization. fixes #4702