WordPress.org

Make WordPress Core

Opened 16 months ago

Closed 6 months ago

#47043 closed defect (bug) (fixed)

i18n: Merge similar translation strings - database related strings

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-screenshots has-patch commit
Focuses: administration Cc:

Description

See the attached screenshots.

Attachments (6)

47043.png (61.5 KB) - added by ramiy 16 months ago.
47043a.png (49.2 KB) - added by ramiy 16 months ago.
47043b.png (41.3 KB) - added by ramiy 16 months ago.
47043c.png (38.1 KB) - added by ramiy 16 months ago.
47043.patch (2.9 KB) - added by ramiy 16 months ago.
47043.installation.png (31.2 KB) - added by SergeyBiryukov 6 months ago.

Download all attachments as: .zip

Change History (17)

@ramiy
16 months ago

@ramiy
16 months ago

@ramiy
16 months ago

@ramiy
16 months ago

@ramiy
16 months ago

#1 @ramiy
16 months ago

  • Focuses administration added
  • Keywords has-screenshots has-patch added

This ticket was mentioned in Slack in #core-php by sergey. View the logs.


16 months ago

#3 @ramiy
15 months ago

  • Keywords site-health added

#4 @desrosj
14 months ago

  • Component changed from General to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#5 @ramiy
9 months ago

@SergeyBiryukov @desrosj Can you change the ticket milestone to 5.4 ?

#6 @SergeyBiryukov
8 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Status changed from assigned to reviewing

This ticket was mentioned in Slack in #core-site-health by clorith. View the logs.


6 months ago

#8 @Clorith
6 months ago

  • Keywords commit added; site-health removed

Looks good to me, marking for commit so we can get them changed before beta.

This ticket was mentioned in Slack in #core by clorith. View the logs.


6 months ago

#10 @SergeyBiryukov
6 months ago

The changes in class-wp-debug-data.php look good, however I would keep the config setup screen as is:

  • "Username" and "Password" look better there, otherwise there's a lot of "database" repetition, considering also the comments on the right side.
  • I'm not sure the title case of those labels should be changed, as they are capitalized on the next installation screen, see 47043.installation.png. It looks like we're just changing one inconsistency for another.

#11 @SergeyBiryukov
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47268:

Site Health: Adjust "Database username" and "Table prefix" strings for consistency with the same strings in wp-admin/setup-config.php.

Props ramiy.
Fixes #47043.

Note: See TracTickets for help on using tickets.