Opened 6 years ago
Last modified 8 months ago
#47044 assigned defect (bug)
Twenty Nineteen: Add padding for full-aligned text blocks inside of a full-width column block.
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | Future Release | Priority: | normal |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-screenshots has-patch changes-requested |
Focuses: | Cc: |
Description
As noted by @dianeco, after #46999, text-based blocks inside of a full-width columns block now bump up against the edges of the screen:
In the case of media/image blocks, it's likely that users will want these to bump right up against the edge of the page, so we should try adding some padding only to text-based blocks if possible.
Note that this needs to be fixed in both the editor and front-end.
Attachments (4)
Change History (14)
#2
@
6 years ago
- Keywords has-patch needs-testing added
- Milestone changed from Awaiting Review to 5.3
#3
@
5 years ago
- Milestone changed from 5.3 to Future Release
This ticket hasn't seen any movement this cycle. With 5.3 RC1 approaching, this is being moved to Future Release
. If a committer feels strongly about this one being in 5.3 and has the time to see it through, it can be moved back up.
#6
@
9 months ago
- Keywords changes-requested added; commit removed
Sadly in testing I can see this in the front resolves it but not in the editor. This means we need to have a patch that also fixes in the editor I think using the latest patch.
#8
@
9 months ago
- Keywords needs-testing removed
- Owner karmatosed deleted
@sabernhardt yes I resolved that in the other issue, apologies for not looping back here. I am going to. unassign myself as what needs to happen here is the following:
- Changes to the patch to make sure this works on both front and editor.
- Testing once the patch has been made.
Noting that there's a somewhat related bug in the editor right now:
https://github.com/WordPress/gutenberg/issues/15192
When a column block is set to be fullscreen, The block toolbar for nested blocks is pushed off-screen on the left. Not sure if there is also some block padding that's being pushed off-screen.