WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 6 weeks ago

#47044 new defect (bug)

Twenty Nineteen: Add padding for full-aligned text blocks inside of a full-width column block.

Reported by: kjellr Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing
Focuses: Cc:
PR Number:

Description

As noted by @dianeco, after #46999, text-based blocks inside of a full-width columns block now bump up against the edges of the screen:

https://cldup.com/KnBH49tlCQ-3000x3000.png

In the case of media/image blocks, it's likely that users will want these to bump right up against the edge of the page, so we should try adding some padding only to text-based blocks if possible.

Note that this needs to be fixed in both the editor and front-end.

Attachments (3)

47044.diff (3.0 KB) - added by ianbelanger 5 months ago.
Adds padding to all items in column block, except images
47044-before-patch.PNG (638.4 KB) - added by ianbelanger 5 months ago.
47044-after-patch.PNG (641.5 KB) - added by ianbelanger 5 months ago.

Download all attachments as: .zip

Change History (6)

#1 @kjellr
7 months ago

Noting that there's a somewhat related bug in the editor right now:

https://github.com/WordPress/gutenberg/issues/15192

When a column block is set to be fullscreen, The block toolbar for nested blocks is pushed off-screen on the left. Not sure if there is also some block padding that's being pushed off-screen.

@ianbelanger
5 months ago

Adds padding to all items in column block, except images

#2 @ianbelanger
5 months ago

  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 5.3

#3 @davidbaumwald
6 weeks ago

  • Milestone changed from 5.3 to Future Release

This ticket hasn't seen any movement this cycle. With 5.3 RC1 approaching, this is being moved to Future Release. If a committer feels strongly about this one being in 5.3 and has the time to see it through, it can be moved back up.

Note: See TracTickets for help on using tickets.