WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 5 months ago

Last modified 5 months ago

#47062 closed defect (bug) (fixed)

indentation on WP Multisite creation page

Reported by: sebastienserre Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: good-first-bug has-patch
Focuses: multisite Cc:
PR Number:

Description

Hello,

On

/wp-admin/network.php

the .htaccess block isn't well indented
https://i.imgur.com/yNsq0wu.png

Attachments (1)

47062.diff (2.2 KB) - added by riddhiehta02 5 months ago.

Download all attachments as: .zip

Change History (9)

#1 @SergeyBiryukov
6 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.3

#2 @SergeyBiryukov
6 months ago

Introduced in [43571].

#3 @sebastienserre
5 months ago

Hello,

I'm reading my own ticket and think, I've forgotten some info.

The part on the .htaccess rules are on

/wp-admin/includes/network.php

line 624

$htaccess_file = <<<EOF
RewriteEngine On
RewriteBase {$base}
RewriteRule ^index\.php$ - [L]
{$ms_files_rewriting}
# add a trailing slash to /wp-admin
RewriteRule ^{$subdir_match}wp-admin$ {$subdir_replacement_01}wp-admin/ [R=301,L]

RewriteCond %{REQUEST_FILENAME} -f [OR]
RewriteCond %{REQUEST_FILENAME} -d
RewriteRule ^ - [L]
RewriteRule ^{$subdir_match}(wp-(content|admin|includes).*) {$rewrite_base}{$subdir_replacement_12} [L]
RewriteRule ^{$subdir_match}(.*\.php)$ {$rewrite_base}$subdir_replacement_12 [L]
RewriteRule . index.php [L]

EOF;

but I don't see any tabs more... so I don't know if it's a WP bug or something wrong on my side.

@riddhiehta02
5 months ago

#4 @riddhiehta02
5 months ago

  • Keywords needs-patch removed

#5 @riddhiehta02
5 months ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core by sergey. View the logs.


5 months ago

#7 @SergeyBiryukov
5 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 45390:

Networks and Sites: Remove extra whitespace in .htaccess rules on Network Setup page.

Props riddhiehta02 for initial patch, sebastienserre, masterforwordpress.
Fixes #47062.

#8 @SergeyBiryukov
5 months ago

In 45391:

Networks and Sites: Readjust tabs in wp-admin/includes/network.php for (more or less) consistent alignment.

See #47062.

Note: See TracTickets for help on using tickets.