Changes between Initial Version and Version 1 of Ticket #47069, comment 74
- Timestamp:
- 12/10/2019 08:18:38 PM (7 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #47069, comment 74
initial v1 4 4 Yeah, it's either that or perhaps wrapping the whole thing in a `try {} catch () {}`. Checking node existence seems cleaner, perhaps? :) 5 5 6 Also not really sure about the `Element.prototype.matches()` polyfill: https://developer.mozilla.org/en-US/docs/Web/API/Element/matches. It's not a bad idea, but might bring some compatibility issues eventually? Need to keep in mind that this will run on the front-end for logged-in users. Generally the browsers they use should conform to the minimal browser support for wp-admin (IE11, newer edge, Chromium and Firefox) but having some "error silencing" for old browsers (to emulate jQuery behaviour) may be a good idea.6 Also not really sure about the `Element.prototype.matches()` polyfill: https://developer.mozilla.org/en-US/docs/Web/API/Element/matches. It's not a bad idea, but might bring some compatibility issues eventually? Need to keep in mind that this will run on the front-end for logged-in users. Generally the browsers they use should conform to the minimal browser support for wp-admin (IE11, newer Edge, Chromium and Firefox) but having some "error silencing" for old browsers (to emulate jQuery behaviour) may be a good idea.