Building may fail to generate *-rtl.css files in wp-includes/css

[azaozz]

Happens when running grunt (build) after grunt --dev was run. In this case there are *.min.css, *-rtl.css and *-rtl.min.css files in both src/wp-admin/css/ and src/wp-includes/css directories. That seems to trip RTLCSS as it tries to process minified and already processed files.

[azaozz]

In 47078.diff:

• Exclude minified and already processed files when running the rtlcss:core task.
• Also delete wp-includes/css/dist directory when running clean:css task.
• Add svnignore *-rtl.css on wp-includes/css.

[desrosj]

I was able to reproduce this and 47078.diff​ fixes the problem, but the wp-includes/css/dist folder is never recreated when running either command (grunt --dev or grunt (build)).

[azaozz]

but the wp-includes/css/dist folder is never recreated

Right, it is created but then "cleaned" right after. Happens because wp-includes/css/dist is created by webpack which runs in build:js. Then we get to build:css which does clean:css and removes /dist.

Looking a but "deeper", we don't really need to do any of that clean:js, clean:css stuff in /build. All WP files are deleted there anyway. Perhaps we should make these run only for grunt --dev and of course for grunt clean --dev, grunt clean:css --dev etc. We should also split the clean tasks from the build tasks and do the cleaning before we run webpack.

For now lets fix this ticket by excluding the src/wp-includes/css/dist directory from processing with rtlcss.

[azaozz]

In 47078.1.diff: exclude minified and already processed files, and files from external packages when running the rtlcss task.

[desrosj]

47078.1.diff​ works perfectly for me, @azaozz.

[azaozz]

In 45317:

Build tools: fix generating *-rtl.css files in wp-includes/css after grunt --dev was used.

Fixes #47078.

[azaozz]

Replying to desrosj:

Thanks for testing! :)

I'm actually not sure if this needs merging to the 5.2 branch. Seems sufficient to fix in trunk. Feel free to reopen and merge there if needed.

[johnbillion]

These files need to be ignored in .gitignore too.

[johnbillion]

In 45410:

Build/Test Tools: Ignore generated RTL CSS files from Git version control.

Fixes #47078