WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#47079 closed defect (bug) (fixed)

Incorrect version for excerpt_allowed_blocks filter

Reported by: rabmalin's profile rabmalin Owned by: desrosj's profile desrosj
Milestone: 5.2.3 Priority: normal
Severity: normal Version: 5.0
Component: General Keywords: good-first-bug has-patch needs-testing fixed-major
Focuses: docs Cc:

Description

Since parameter is incorrect for excerpt_allowed_blocks filter.

Currently it is @since 4.4.0.
May be it should be 5.0.0.

Ref - wp-includes/blocks.php line 152

Attachments (1)

47079.diff​ (470 bytes) - added by mukesh27 6 years ago.
Patch added.

Download all attachments as: .zip

Change History (11)

#1 @desrosj
6 years ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to 5.2.1
  • Version changed from 5.1.1 to 5.0

Thanks, @rabmalin!

Indeed, this should be noted as @since 5.0.

@mukesh27
6 years ago

Patch added.

#2 @mukesh27
6 years ago

  • Keywords has-patch added; needs-patch removed

@desrosj, Need to update version in ​https://developer.wordpress.org/reference/hooks/excerpt_allowed_blocks/ document.

#3 @desrosj
6 years ago

  • Keywords commit added
  • Owner set to desrosj
  • Status changed from new to assigned

Thanks, @mukesh27. That documentation is auto generated on releases. It should correct itself after this code ships.

#4 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45284:

Editor: Correct since annotation for the excerpt_allowed_blocks filter.

Props mukesh27, rabmalin.
Fixes #47079.

#5 @desrosj
6 years ago

  • Keywords fixed-major added; commit removed

Reopening for backport consideration.

#6 @desrosj
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

#7 @desrosj
6 years ago

  • Keywords fixed-major removed
  • Milestone changed from 5.2.1 to 5.3

Let's leave this just in 5.3.

#8 @desrosj
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

#9 @JeffPaul
6 years ago

  • Keywords needs-testing fixed-major added
  • Milestone changed from 5.3 to 5.2.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening this so it can be back-ported to the 5.2 branch, also needs testing to validate if this ticket is good to land in 5.2.3.

#10 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45836:

Editor: Correct since annotation for the excerpt_allowed_blocks filter.

Props mukesh27, rabmalin.
Merges [45284] to the 5.2 branch.
Fixes #47079.

Note: See TracTickets for help on using tickets.