WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 4 months ago

#47087 closed defect (bug) (fixed)

flush_rewrite_rules() should check $wp_rewrite->flush_rules() is callable before calling it

Reported by: markjaquith Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Rewrite Rules Keywords: good-first-bug has-patch
Focuses: Cc:
PR Number:

Description

I ran into this situation:

Uncaught Error: Call to a member function flush_rules() on null

when some code was running flush_rewrite_rules() on shutdown.

flush_rewrite_rules() should do a sanity check before calling, so it never causes a fatal error.

Attachments (1)

47087.diff (455 bytes) - added by bsetiawan88 7 months ago.

Download all attachments as: .zip

Change History (4)

#1 @desrosj
7 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

@bsetiawan88
7 months ago

#2 @SergeyBiryukov
7 months ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Future Release to 5.3
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45699:

Rewrite Rules: Check if $wp_rewrite->flush_rules() is callable before calling it in flush_rewrite_rules().

Props bsetiawan88, markjaquith.
Fixes #47087.

Note: See TracTickets for help on using tickets.