![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 7 years ago
Closed 7 years ago
#47092 closed enhancement (fixed)
Increase the usefullness of 'random_password' by adding additional parameters
| Reported by: | roytanck | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.3 |
| Component: | Login and Registration | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: |
Description
In the wp_generate_password function, the output is run through the 'random_password' hook. This allows other functions to modify or replace the generated password. But because the $special_chars and $extra_special_chars parameters are not passed to the hook, any hooked function does not know whether special chars are allowed.
This limits the hooks usefulness, since wp_generate_password is also used to generate tokens that needs to be url-safe. By passing the two extra arguments along in the filter, hooked functions can respects these requirements.
I realize wp_generate_password is a pluggable function, but I feel that using the hook is a much cleaner way to override/improve WP's password suggestions.
Patch adding $special_chars and $extra_special_chars to the 'random_password' hook.