Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#47102 closed defect (bug) (duplicate)

Twenty Nineteen: SVG author badge printed twice

Reported by: marctison75's profile marctison75 Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

In class-twentynineteen-walker-comment.php, the svg author badge is written twice. Is it intended?

/*
* Using the `check` icon instead of `check_circle`, since we can't add a
* fill color to the inner check shape when in circle form.
*/
if ( twentynineteen_is_comment_by_post_author( $comment ) ) {
printf( '<span class="post-author-badge" aria-hidden="true">%s</span>', twentynineteen_get_icon_svg( 'check', 24 ) );
 }

/*
* Using the `check` icon instead of `check_circle`, since we can't add a
* fill color to the inner check shape when in circle form.
*/
if ( twentynineteen_is_comment_by_post_author( $comment ) ) {
printf( '<span class="post-author-badge" aria-hidden="true">%s</span>', twentynineteen_get_icon_svg( 'check', 24 ) );
}

Attachments (1)

47102.diff (897 bytes) - added by garrett-eclipse 6 years ago.
Patch to remove duplicate post-author-badge code.

Download all attachments as: .zip

Change History (5)

@garrett-eclipse
6 years ago

Patch to remove duplicate post-author-badge code.

#1 @garrett-eclipse
6 years ago

  • Keywords has-patch needs-testing added
  • Version changed from trunk to 5.1

Thanks for the report @marctison75 good catch. I think this was simply an accidental duplication. I've removed one in 47102.diff. It appears this was introduced in 5.1.

#2 @mukesh27
6 years ago

  • Keywords needs-testing removed
  • Resolution set to duplicate
  • Status changed from new to closed
  • Version 5.1 deleted

Thanks for reporting this, @marctison75! It seems this was reported already in #46455. I am going to close this one.

Feel free to reopen if you think issue is different then that.

#3 @garrett-eclipse
6 years ago

Thanks Mukesh, hadn't seen yours come through.

#4 @SergeyBiryukov
6 years ago

  • Milestone Awaiting Review deleted
Note: See TracTickets for help on using tickets.