#47102 closed defect (bug) (duplicate)
Twenty Nineteen: SVG author badge printed twice
Reported by: | marctison75 | Owned by: | |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: |
Description
In class-twentynineteen-walker-comment.php, the svg author badge is written twice. Is it intended?
/* * Using the `check` icon instead of `check_circle`, since we can't add a * fill color to the inner check shape when in circle form. */ if ( twentynineteen_is_comment_by_post_author( $comment ) ) { printf( '<span class="post-author-badge" aria-hidden="true">%s</span>', twentynineteen_get_icon_svg( 'check', 24 ) ); } /* * Using the `check` icon instead of `check_circle`, since we can't add a * fill color to the inner check shape when in circle form. */ if ( twentynineteen_is_comment_by_post_author( $comment ) ) { printf( '<span class="post-author-badge" aria-hidden="true">%s</span>', twentynineteen_get_icon_svg( 'check', 24 ) ); }
Attachments (1)
Change History (5)
#1
@
6 years ago
- Keywords has-patch needs-testing added
- Version changed from trunk to 5.1
Thanks for the report @marctison75 good catch. I think this was simply an accidental duplication. I've removed one in 47102.diff. It appears this was introduced in 5.1.
#2
@
6 years ago
- Keywords needs-testing removed
- Resolution set to duplicate
- Status changed from new to closed
- Version 5.1 deleted
Thanks for reporting this, @marctison75! It seems this was reported already in #46455. I am going to close this one.
Feel free to reopen if you think issue is different then that.
Note: See
TracTickets for help on using
tickets.
Patch to remove duplicate post-author-badge code.