WordPress.org

Make WordPress Core

Opened 7 months ago

Closed 6 months ago

#47106 closed defect (bug) (fixed)

Add aria-current attribute to current item in WP Admin <nav> tabs

Reported by: audrasjb Owned by: audrasjb
Milestone: 5.2.1 Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-patch commit fixed-major
Focuses: accessibility Cc:
PR Number:

Description

WordPress Admin screens that use tabs navigation should use aria-current attribute on <nav> elements.

For full details, see #47094

Milestoned in 5.2.1 since this regression have been introduced in 5.2 (see #43398)

Current implementation:

    <li>
        <a href="...">...</a>
    </li>

Recommended code:

    <li>
        <a href="..." aria-current="page">...</a>
    </li>
   a[aria-current] {
        /*  styles */
    }

Attachments (2)

47106.diff (5.7 KB) - added by audrasjb 7 months ago.
adds aria-current attribute to Admin nav tabs
47106.2.diff (13.3 KB) - added by afercia 7 months ago.

Download all attachments as: .zip

Change History (8)

#1 @audrasjb
7 months ago

That should be fixed in:

  • Menu screen
  • About.php screen – Edit: + Credits, Freedoms, Privacy :)
  • Edit site screen (in multisites)
Last edited 7 months ago by afercia (previous) (diff)

@audrasjb
7 months ago

adds aria-current attribute to Admin nav tabs

#2 @audrasjb
7 months ago

  • Keywords has-patch added; needs-patch removed

@afercia
7 months ago

#3 @afercia
7 months ago

  • Keywords commit added

In 47106.2.diff:

  • adjustments for the wp-admin/nav-menus.php page
  • makes phpcs happy
  • fixes some (pre-existing) missing translators comments to make phpcs even happier

#4 @afercia
7 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45300:

Accessibility: Add aria-current to the links in the <nav> elements introduced in [44905].

Also fixes a few translators comments and coding standards.

Props audrasjb.
Fixes #47106.

#5 @afercia
7 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.2.1 consideration.

#6 @desrosj
6 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45318:

Accessibility: Add aria-current to the links in the <nav> elements introduced in [44905].

Also fixes a few translators comments and coding standards.

Merges [45300] to the 5.2 branch.

Props audrasjb, afercia.
Fixes #47106.

Note: See TracTickets for help on using tickets.