WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#47128 closed defect (bug) (fixed)

Twenty Nineteen: Remove duplicate height and width attribute from SVG icon

Reported by: mukesh27's profile mukesh27 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch good-first-bug
Focuses: coding-standards Cc:

Description

W3C shows duplicate height and width error in SVG icons.

W3C error:

Error: Duplicate attribute width.
Error: Duplicate attribute height.

Attachments (1)

47128.diff​ (1.2 KB) - added by mukesh27 5 years ago.
Patch.

Download all attachments as: .zip

Change History (6)

@mukesh27
5 years ago

Patch.

#1 @mukesh27
5 years ago

#47455 was marked as a duplicate.

#2 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.3

#3 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @desrosj
5 years ago

#47455 was marked as a duplicate.

#5 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45760:

Twenty Nineteen: Remove duplicate height and width attributes from SVG icons.

The attributes are added via TwentyNineteen_SVG_Icons::get_svg(), there's no need to have them separately in SVG sources.

Props mukesh27, albertomake.
Fixes #47128.

Note: See TracTickets for help on using tickets.