Merge similar strings introduced in WP 5.2

[dimadin]

There are strings introduced in WordPress 5.2 that can be modified to reuse existing strings. No new strings are introduced with attached patch.

---

PHP is the programming language we use to build and maintain WordPress. Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site’s performance.

and

PHP is the programming language we use to build and maintain WordPress. Newer versions of PHP are both faster and more secure, so updating will have a positive effect on your site’s performance.

This is the only example where ’ is used in strings in PHP files, so I propose using string with HTML entity instead.

---

The authenticity of %1$s could not be verified as signature verification is unavailable on this system.

and

The authenticity of %s could not be verified as signature verification is unavailable on this system.

While in [45167] numbered placeholder was removed for second string, [45262] introduced first string, probably because patch was made before [45167] was committed.

---

<?php
/* translators: %s: number of ratings */
echo sprintf( __( '(%s ratings) <span class="screen-reader-text">link to view ratings opens in a new tab</span>' ), '{{ data.num_ratings }}' );

and

<?php
printf(
        '%1$s<span class="screen-reader-text"> %2$s</span>',
        /* translators: %s: number of ratings */
        sprintf( __( '(%s ratings)' ), '{{ data.num_ratings }}' ),
        /* translators: accessibility text */
        __( '(opens in a new tab)' )
);

The first string was unnecessary introduced in [44975]. There were already solutions for both main and accessibility texts.

---

'The email could not be sent.' ) . "<br />\n" . __( 'Possible reason: your host may have disabled the mail() function.'

and

'The email could not be sent. Possible reason: your host may have disabled the mail() function.'

In the error in the past, this message was split in two strings merged with <br> tag. [44973] introduced this message as one string. I don't think there is need for old case and instead I propose to always use message in one string.

[ramiy]

@desrosj We usually don't change translation strings in minor versions. You should change the Milestone to 5.3.0

[dimadin]

@ramiy Like I said in a ticket description, this will not introduce any new string.

[desrosj]

Thanks @dimadin. I reviewed and can confirm no new strings are introduced, only consolidation.

[desrosj]

In 45298:

I18N: Combine similar strings with minor differences.

Props dimadin.
Fixes #47158.

[desrosj]

Reopening for backport consideration.

[ramiy]

Related: #47040

[SergeyBiryukov]

#47040 was marked as a duplicate.

[SergeyBiryukov]

Replying to desrosj:

Reopening for backport consideration.

Looks like this wasn't actually reopened, moving for 5.2.2 consideration.

[audrasjb]

Hi @desrosj @SergeyBiryukov do you think we can have a backport for this ticket today so we can ship that on 5.2.2 RC1?
Thank you! The RC processing is going to start at 19:00 UTC.

[desrosj]

In 45510:

I18N: Combine similar strings with minor differences.

Merges [45298] to the 5.2 branch.

Props dimadin.
Fixes #47158.