Make WordPress Core

Opened 7 years ago

Closed 7 months ago

#47165 closed enhancement (duplicate)

Admin menu: submenu for active menu doesn't have box-shadow

Reported by: man4toman's profile man4toman Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Administration Keywords: has-screenshots has-patch
Focuses: ui Cc:

Description

Submenu for active menu doesn't have box-shadow, please check screenshots.

Attachments (3)

01.png (9.6 KB) - added by man4toman 7 years ago.
02.png (10.3 KB) - added by man4toman 7 years ago.
47165.diff (300 bytes) - added by mukesh27 7 years ago.
Patch.

Download all attachments as: .zip

Change History (13)

@man4toman
7 years ago

@man4toman
7 years ago

#1 @man4toman
7 years ago

Maybe related with: #47132

Last edited 7 years ago by man4toman (previous) (diff)

@mukesh27
7 years ago

Patch.

#2 @mukesh27
7 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

This ticket was mentioned in Slack in #design by estelaris. View the logs.


6 years ago

#4 @kjellr
6 years ago

Thanks for the patch, @mukesh27! I just tested, and I think the fix will need to be slightly more complicated: I'm seeing the drop shadow applied when the menu is expanded as well now:

https://cldup.com/LuVi7dCWsn.png

Ideally, that shadow should only show up when the left menu is collapsed, and when the active item is opened up.

#5 @nrqsnchz
6 years ago

Hey @mukesh27! I can confirm what Kjell commented. While the patch adds the missing drop shadow to the flyout menu, it's also adding it to the expanded menu.

https://cldup.com/NW5ileJTcX.png

#6 @JavierCasares
6 years ago

Hello, I tried this and, I think it works...

#adminmenu .wp-has-current-submenu.opensub .wp-submenu
{
  box-shadow: 0 3px 5px rgba(0,0,0,.2);
}

This ticket was mentioned in Slack in #design by estelaris. View the logs.


5 years ago

#8 @anyssa
5 years ago

  • Keywords dev-feedback added; needs-design-feedback removed

As discussed today during design triage, I'm removing the keyword needs-design-feedback, since it seems to be a CSS selector issue at this point.

#9 @callumbw95
7 months ago

  • Keywords close added

Hi all,

I have just taken a look at this, and I am no longer seeing this issue within the latest release of WordPress and this issue looks to have been resolved now. As of such I believe we can safely close down this ticket, and have added the close tag.

#10 @sabernhardt
7 months ago

  • Keywords needs-testing dev-feedback close removed
  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

Duplicate of #32579.

Yes, it apparently was fixed by part of [50549]:

.folded #adminmenu .wp-has-current-submenu .wp-submenu {
  box-shadow: 0 3px 5px rgba(0, 0, 0, 0.2);
}
Note: See TracTickets for help on using tickets.