WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 2 months ago

#47165 new enhancement

Admin menu: submenu for active menu doesn't have box-shadow

Reported by: man4toman Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Administration Keywords: needs-design-feedback has-screenshots has-patch needs-testing
Focuses: ui Cc:
PR Number:

Description

Submenu for active menu doesn't have box-shadow, please check screenshots.

Attachments (3)

01.png (9.6 KB) - added by man4toman 6 months ago.
02.png (10.3 KB) - added by man4toman 6 months ago.
47165.diff (300 bytes) - added by mukesh27 6 months ago.
Patch.

Download all attachments as: .zip

Change History (8)

@man4toman
6 months ago

@man4toman
6 months ago

#1 @man4toman
6 months ago

Maybe related with: #47132

Last edited 6 months ago by man4toman (previous) (diff)

@mukesh27
6 months ago

Patch.

#2 @mukesh27
6 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

This ticket was mentioned in Slack in #design by estelaris. View the logs.


2 months ago

#4 @kjellr
2 months ago

Thanks for the patch, @mukesh27! I just tested, and I think the fix will need to be slightly more complicated: I'm seeing the drop shadow applied when the menu is expanded as well now:

https://cldup.com/LuVi7dCWsn.png

Ideally, that shadow should only show up when the left menu is collapsed, and when the active item is opened up.

#5 @nrqsnchz
2 months ago

Hey @mukesh27! I can confirm what Kjell commented. While the patch adds the missing drop shadow to the flyout menu, it's also adding it to the expanded menu.

https://cldup.com/NW5ileJTcX.png

Note: See TracTickets for help on using tickets.