Comment reply links are always to first comment form on a page when $withcomments variable is set to true

[johnh10]

This is a follow-up to #33383.

This bug has returned. I'm not sure which version re-introduced this, but the original fix for #33383 (get_permalink) is missing in the current comments-template.php

The WordPress v5.2 code starting at line 1695 of comments-template.php should be:

<?php
                $link = sprintf(
                        "<a rel='nofollow' class='comment-reply-link' href='%s' %s aria-label='%s'>%s</a>",
                        esc_url(
                                add_query_arg(
                                        array(
                                                'replytocom'      => $comment->comment_ID,
                                                'unapproved'      => false,
                                                'moderation-hash' => false,
                                        ),
                                        get_permalink($post->ID)
                                )
                        ) . '#' . $args['respond_id'],
                        $data_attribute_string,
                        esc_attr( sprintf( $args['reply_to_text'], $comment->comment_author ) ),
                        $args['reply_text']
                );

After adding the get_permalink line it works as expected.

[justinahinon]

Hi @johnh10
Just created a patch for this. I'll track the previous versions changesets to find out where the last one has been removed.

[earnjam]

Looks like that get_permalink() arg was removed in [42360], so I think this came back in 5.1.

[donmhico]

Added unit test.

[donmhico]

I added unit test in my patch - 47174.2.diff.

Seeing that this issue "resurfaced", a unit test would be beneficially to prevent this from happening again.

[peterwilsoncc]

Thanks @donmhico, you read my mind!

47174.3.diff​ is almost identical to version 2 with the following changes:

• some coding standards fixes
• renamed a couple of variables for clarity to indicate they contain IDs rather than objects

[donmhico]

@peterwilsoncc - No problem. I'm reviewing your changes so my future patches would be better. Thank you as well.

[peterwilsoncc]

In 45787:

Comments: Include post permalink in comment reply link.

Include the post's permalink when generating reply links in get_comment_reply_link() to account for comments displayed on index and archive pages.

This reapplies [32786] which was inadvertently reverted in [42360].

Props justinahinon, donmhico.
See #33383.
Fixes #47174.