Twenty Ten: Remove an extra colons from blocks.css

[shashank3105]

Found many extra colons from many files and removed those.

Thanks,
Shashank.

[shashank3105]

Patch file for this issue

[man4toman]

Hi @shashank3105
Please remove rtl.css from the patch, the rtl files will generate automatically and doesn't need any modification.

[man4toman]

Also, sodium_compat and getid3 aren't from WordPress core and if they needs any patch, you must send it to their authors.

[shashank3105]

Patch file for this issue and also remove suggested code

[ianbelanger]

Patch looks good and a fairly simple fix. Tagging for 5.3 as the Bundled Themes are only updated during major releases.

[ianbelanger]

Refreshed patch because previous patch did not apply

[desrosj]

I did some digging into the rtl.css file in Twenty Sixteen with the double ; and it appears that this file has not been updated since the theme was moved over to Core's SVN repo. It was also not updated after being added to the ​GitHub repository.

It appears that RTL stylesheets are not automatically generated from the LTR versions in bundled themes prior to Twenty Nineteen (which has its own build process).

Because these are not automatically generated by a build process, it should be safe to remove the double ; in twentysixteen/rtl.css as well.

@laurelfulford Since you have a bit more historic knowledge of the bundled themes, can you confirm?

[laurelfulford]

@desrosj Yes! All of the RTL styles in default themes pre-Twenty Nineteen are manually managed, so it's fine to just remove the extra semi-colon from Twenty Sixteen's RTL styles.

[man4toman]

Is this true for all bundled themes RTL files?
That means we can suggest enhancements for RTL files directly.

[ianbelanger]

Updates patch to include 2016 RTL fix

[SergeyBiryukov]

In 45592:

Bundled Themes: Remove extra semicolons from CSS files.

Props shashank3105, ianbelanger.
Fixes #47178.