WordPress.org

Make WordPress Core

Opened 7 weeks ago

Last modified 13 days ago

#47178 new defect (bug)

Twenty Ten: Remove an extra colons from blocks.css

Reported by: shashank3105 Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch commit
Focuses: coding-standards Cc:

Description

Found many extra colons from many files and removed those.

Thanks,
Shashank.

Attachments (4)

#47178-shashank3105.patch (3.4 KB) - added by shashank3105 7 weeks ago.
Patch file for this issue
shashank3105.patch (304 bytes) - added by shashank3105 7 weeks ago.
Patch file for this issue and also remove suggested code
47178.1.diff (395 bytes) - added by ianbelanger 7 weeks ago.
Refreshed patch because previous patch did not apply
47178.2.diff (949 bytes) - added by ianbelanger 13 days ago.
Updates patch to include 2016 RTL fix

Download all attachments as: .zip

Change History (13)

@shashank3105
7 weeks ago

Patch file for this issue

#1 @man4toman
7 weeks ago

Hi @shashank3105
Please remove rtl.css from the patch, the rtl files will generate automatically and doesn't need any modification.

#2 @man4toman
7 weeks ago

Also, sodium_compat and getid3 aren't from WordPress core and if they needs any patch, you must send it to their authors.

@shashank3105
7 weeks ago

Patch file for this issue and also remove suggested code

#3 @SergeyBiryukov
7 weeks ago

  • Focuses coding-standards added

#4 @mukesh27
7 weeks ago

  • Component changed from General to Bundled Theme
  • Keywords needs-testing removed
  • Summary changed from Remove extra colons from many files to Twenty Ten: Remove an extra colons from blocks.css

#5 @ianbelanger
7 weeks ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.3

Patch looks good and a fairly simple fix. Tagging for 5.3 as the Bundled Themes are only updated during major releases.

@ianbelanger
7 weeks ago

Refreshed patch because previous patch did not apply

#6 @desrosj
6 weeks ago

  • Keywords needs-refresh added; commit removed

I did some digging into the rtl.css file in Twenty Sixteen with the double ; and it appears that this file has not been updated since the theme was moved over to Core's SVN repo. It was also not updated after being added to the GitHub repository.

It appears that RTL stylesheets are not automatically generated from the LTR versions in bundled themes prior to Twenty Nineteen (which has its own build process).

Because these are not automatically generated by a build process, it should be safe to remove the double ; in twentysixteen/rtl.css as well.

@laurelfulford Since you have a bit more historic knowledge of the bundled themes, can you confirm?

#7 @laurelfulford
6 weeks ago

@desrosj Yes! All of the RTL styles in default themes pre-Twenty Nineteen are manually managed, so it's fine to just remove the extra semi-colon from Twenty Sixteen's RTL styles.

#8 @man4toman
6 weeks ago

Is this true for all bundled themes RTL files?
That means we can suggest enhancements for RTL files directly.

@ianbelanger
13 days ago

Updates patch to include 2016 RTL fix

#9 @ianbelanger
13 days ago

  • Keywords commit added; needs-refresh removed
Note: See TracTickets for help on using tickets.