WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #47186, comment 26


Ignore:
Timestamp:
05/10/2019 03:01:50 AM (15 months ago)
Author:
paragoninitiativeenterprises
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #47186, comment 26

    initial v1  
    11Both patches (47186.patch and 47186-update_sodium_compat_to_v1_9_3.patch) solve the problem differently.
    22
    3 The first skips when the timeout is > 40 seconds, because a reported runtime of ~30 seconds was causing timeouts. Looking at this patch in isolation, it makes sense to bump it to 60.
     3The first skips when the timeout is less than 40 seconds, because a reported runtime of ~30 seconds was causing timeouts. Looking at this patch in isolation, it makes sense to bump it to 60.
    44
    55However, the second makes the process ''much'' faster. My benchmarks are 4-5x faster for Ed25519 verification and 9-10x faster for the test suites, although others' mileage will certainly vary.