Make WordPress Core

Opened 5 years ago

Last modified 3 years ago

#47187 accepted defect (bug)

<!--more--> tag on same line as content prevents any edits to that line

Reported by: archon810's profile archon810 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.2
Component: Editor Keywords: needs-testing
Focuses: Cc:

Description

Hi,

We have noticed a bug in WordPress that prevents any edits to the line with a <!--more--> tag if the tag is on the same line at the end, like so:

Test. <!--more-->

Test2

If you enter this into Text mode, then switch to Visual mode and move the cursor right after "Test." you won't be able to insert any characters.

I tested this on 5.1 and 5.2.

Attachments (2)

more-classical.jpg (26.7 KB) - added by birgire 5 years ago.
more-code.jpg (15.3 KB) - added by birgire 5 years ago.

Download all attachments as: .zip

Change History (16)

#1 @archon810
5 years ago

Hi,

Any updates on triaging this ticket?

Our writers are complaining that the read more tag inserts on the same line all the time and prevents edits as described.

Thanks.

#2 @birgire
5 years ago

Thanks for the report @archon810

Are you using any plugins, like the Classical Editor, since you mentioned Visual & Text mode?

Are there any Javascript errors in the console?

I was unsuccessful replicating this in the classical editor, in WordPress 5.2 with the Classical Editor plugin activated.

#3 @archon810
5 years ago

Hi,

We do have the Classic Editor plugin active. I can confirm no errors in the console.

Disabling plugins on a dockerized spin-up currently, let's see if it's any of them.

#4 @archon810
5 years ago

Hi again,

I've deactivated every plugin except for Classic Editor. I also switched our theme to twentynineteen.

https://i.imgur.com/K9m0IbV.png

I can still reproduce the issue (in Chrome stable 74 on Windows 10 at least). For example, I can't press "space" at the end of the line after "Wi-Fi settings.":
https://i.imgur.com/ntUFtE9.png
https://i.imgur.com/pqBOyHk.png

#5 @archon810
5 years ago

In fact, this is happening in the block editor too, with the Classic Editor disabled.

Here's a screencast demo - note that you only can't add spaces at the end there - other chars work OK.

https://i.imgur.com/ZpWTzY9.gifv

@birgire I hope you can reproduce this now.

@birgire
5 years ago

#6 @birgire
5 years ago

Thank you for the screencast and screenshots @archon810

It was helpful.

I can now confirm the error on my vanilla 5.2 install when I create a new post in the block editor, with the example in more-code.jpg

No Javascript error in console.

Space is not working just after "after" and right before "before" in more-classical.jpg

#7 @birgire
5 years ago

@archon810

I wonder if you could verify another strange thing

  • Then I delete only the a character with the backspace button, so that the cursor is now at the beginning of the line (left).
  • Then I press the space button few times and it will act like the delete button on the spaces to the right, until it hits f without deleting it.
Last edited 5 years ago by birgire (previous) (diff)

#8 @archon810
5 years ago

@birgire I can confirm seeing the same thing. Nice spot - this bug is even weirder. Can we get someone to take a look at what's causing it?

#9 @pento
5 years ago

  • Keywords reporter-feedback added

I'm unable to reproduce this issue in trunk: are you able to reproduce it there?

#10 @archon810
5 years ago

@pento Just tested on github master (http://develop.svn.wordpress.org/trunk/src/ is missing wp-includes/js and is all sorts of broken for me), and I can still reproduce this issue.

#11 @archon810
4 years ago

Any updates?

#13 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#14 @noisysocks
3 years ago

  • Keywords needs-testing added; reporter-feedback removed
Note: See TracTickets for help on using tickets.