Site Health: Plugins Upgrade Link for Multisite

[sebastienserre]

Hello,

On a multisite, Site Health says "Manage your plugins" & "Update your plugins" with link to /wp-admin/plugins.php but in Multisite the linbk should be /wp-admin/network/plugins.php where the upgrade is possible.

[jeremyfelt]

Good call, @sebastienserre. I think it makes sense to adjust the URL to better fit the context of that action.

[audrasjb]

@jeremyfelt since this feature was introduced in 5.2, I would say it can fit to the next minor, isn't it? (cc @clorith)

[sebastienserre]

I'm on a patch and I think the update link should be network/update-core.php and manage plugin to network/plugins.php

[jeremyfelt]

Replying to audrasjb:

since this feature was introduced in 5.2, I would say it can fit to the next minor, isn't it?

Very possible! I just avoided making that call myself. :)

@sebastienserre 47189.diff​ is on the right track. There is a network_admin_url() function that is available to both single and multisite that should work for this purpose. It has its own is_multisite() check that will return admin_url() when appropriate.

[ocean90]

Note that there's a menu_items site option in multisite which can allow site admins to access plugins at /wp-admin/plugins.php.

[sebastienserre]

I think, y working on this ticket, there's a problem with my patch because a "simpe" administrator will see it and click... but won't be authorized to go on the network level... very frustrating :-(.

This surely have something to do with a current_user_can().

[sebastienserre]

Hello,

Sorry, it's OK as Site Health on MS is only accessible to Super-Admin

[desrosj]

47189.2.diff​ changes only the "Update your plugins" link. Managing plugins can be done within the site context.

I hesitated adding network_admin_url to the "Manage inactive plugins" link. A site administrator that clicks this form a site on a network could incorrectly assume they can just delete plugins that are inactive on that site. But, they could actually be active on other sites.

[Clorith]

I think 47189.2.diff​ is fine.

With regards to the "Manage inactive plugins", this section is unavailable in a multisite setting, so we don't need the network admin URL in that context.

[desrosj]

Ah, you're right, @Clorith! This looks good.

[desrosj]

In 45308:

Site Health: Link to the correct plugin update screen in multisite installs.

Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.

[desrosj]

Reopening for backport consideration.

[desrosj]

In 45313:

Site Health: Link to the correct plugin update screen in multisite installs.

Merges [45308] to the 5.2 branch.

Props Clorith, sebastienserre, jeremyfelt, desrosj.
Fixes #47189.