WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#47227 closed defect (bug) (fixed)

i18n: Merge similar translation strings - site health tabs

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2.2 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-screenshots has-patch site-health fixed-major
Focuses: administration Cc:

Description

Site Health has two files (site-health.php and site-health-info.php). Both use tab navigation. One file use simple _e() functions, the other _ex(). This creates two translations strings in translate.wordpress.org .

The attached patch merges the two translation strings by using context function in both files.

In addition, it remove the translator comments. Not required as the string has context.

Attachments (5)

47227.png​ (6.6 KB) - added by ramiy 5 years ago.
47227.patch​ (1.6 KB) - added by ramiy 5 years ago.
47227a.png​ (13.0 KB) - added by ramiy 5 years ago.
site-health.php
47227b.png​ (13.0 KB) - added by ramiy 5 years ago.
site-health-info.php
47227.2.patch​ (875 bytes) - added by ramiy 5 years ago.

Download all attachments as: .zip

Change History (19)

@ramiy
5 years ago

@ramiy
5 years ago

#1 @ramiy
5 years ago

  • Keywords has-screenshots has-patch added

#2 @ramiy
5 years ago

  • Keywords site-health added

@ramiy
5 years ago

site-health.php

@ramiy
5 years ago

site-health-info.php

#3 @ramiy
5 years ago

In Hebrew we have two different strings in those two pages. Because one uses context function for the site-health page and the other doesn't, and it uses the general "status" which is used as post-status.

#4 @desrosj
5 years ago

  • Milestone changed from Awaiting Review to 5.3

#5 @SergeyBiryukov
5 years ago

  • Milestone changed from 5.3 to 5.2.2

#6 @ocean90
5 years ago

  • Keywords needs-refresh added

Please do not remove the translator comments. They are fine as is even if a context is provided.

@ramiy
5 years ago

#7 @ramiy
5 years ago

  • Keywords needs-refresh removed

This ticket was mentioned in ​Slack in #core-php by marioernestoms. ​View the logs.
5 years ago

This ticket was mentioned in ​Slack in #core by audrasjb. ​View the logs.
5 years ago

#10 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45488:

I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.

Props ramiy.
Fixes #47227.

#11 @SergeyBiryukov
5 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#12 @audrasjb
5 years ago

Hi @SergeyBiryukov do you think we can have a backport for this ticket today so we can ship that on 5.2.2 RC1?
Thank you! The RC processing is going to start at 19:00 UTC.

#13 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 45512:

I18N: Merge duplicate "Status" and "Info" strings on Site Health screens.

Props ramiy.
Merges [45488] to the 5.2 branch.
Fixes #47227.

#14 @spacedmonkey
5 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.