Opened 6 years ago
Closed 4 years ago
#47235 closed defect (bug) (fixed)
i18n: "Back to..." vs. "Return to..."
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.6 | Priority: | low |
Severity: | minor | Version: | |
Component: | Administration | Keywords: | has-patch commit |
Focuses: | administration | Cc: |
Description
In WordPress dashboard some pages have links at the bottom of the screen linking back other screen pages.
The wording is inconsistent, in some cases the we use "Back to..." in other cases we use "Return to..."
Check those links:
Note: some of those strings has "←" char prefix, other use "←" char, but most don't use any prefix.
We need to set a standard.
Attachments (6)
Change History (23)
#2
@
6 years ago
- Keywords has-patch added
The first patch merges similar translation strings. Replacing "Go to..." with "Return to..." strings.
This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.
5 years ago
#5
follow-up:
↓ 6
@
5 years ago
Hi @audrasjb thanks for the refresh, reviewing I see you've updated the 'Go to the Themes/Plugins screen' strings in the paused_themes/plugins_notice functions. To my understanding these notices will take over their respective screens before you even get to view the Themes/Plugins screens so the term 'Return' could be incorrect/misleading as you weren't previously on those pages. To me 'Go to the' is more valid for both the cases where they were on the screen before hand and some where they were coming to the screen for the first time but instead got this notice.
I hope that makes sense, and I could be wrong. If the only way those notices appear are if you start on the Themes/Plugins screen first then I guess the change is valid in that case.
#6
in reply to:
↑ 5
@
5 years ago
Replying to garrett-eclipse:
Hi @audrasjb thanks for the refresh, reviewing I see you've updated the 'Go to the Themes/Plugins screen' strings in the paused_themes/plugins_notice functions. To my understanding these notices will take over their respective screens before you even get to view the Themes/Plugins screens so the term 'Return' could be incorrect/misleading as you weren't previously on those pages. To me 'Go to the' is more valid for both the cases where they were on the screen before hand and some where they were coming to the screen for the first time but instead got this notice.
I hope that makes sense, and I could be wrong. If the only way those notices appear are if you start on the Themes/Plugins screen first then I guess the change is valid in that case.
I agree.
#7
@
5 years ago
- Keywords dev-feedback added
- Priority changed from normal to low
- Severity changed from normal to minor
#8
@
5 years ago
- Keywords needs-refresh added
@kharisblank thanks for the patch update.
It looks like for the most part, it applies cleanly, with one exception in src/wp-admin/includes/class-plugin-installer-skin.php
I've tested it (non-exhaustively) for a Plugin update and it does the job.
Please refresh the patch for the ticket to move forward.
#9
@
5 years ago
- Milestone changed from 5.4 to Future Release
Hi,
With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.
#10
@
4 years ago
- Keywords needs-testing added; needs-refresh removed
- Milestone changed from Future Release to 5.6
Hello, I've refreshed the patch in 47235.5.diff to address the parts that didn't apply cleanly as well as to add the newer 'Return to top' string found in privacy-tools.php to the mix.
@valentinbora @ramiy @SergeyBiryukov please do a final review/test and we'll see if this can make 5.6.
#12
@
4 years ago
- Keywords commit added; dev-feedback needs-testing removed
Adding commit
workflow keyword
#14
@
4 years ago
Good catch thanks @ramiy I noticed that on a different patch and fixed in #50805 which is now in trunk so shouldn't see that come up again. Refreshed to remove them in 47235.6.diff.
Also, some screen use "Go to..." see here.