WordPress.org

Make WordPress Core

Opened 13 months ago

Closed 9 months ago

#47247 closed enhancement (fixed)

i18n: Merge similar translation strings - drop-ins

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Site Health Keywords: has-screenshots site-health has-patch commit
Focuses: administration Cc:

Description

Site Health introduced a new string explaining what are drop-in plugins. We already have a string explaining the same thing, located at the drop-ins tab in the plugins page.

We can rewrite the two strings and use them in both sections.

Attachments (7)

47247.png (57.3 KB) - added by ramiy 13 months ago.
47247.2.png (32.5 KB) - added by ramiy 13 months ago.
47247.3.png (9.7 KB) - added by ramiy 12 months ago.
47247.diff (1.7 KB) - added by garrett-eclipse 11 months ago.
patch to merge strings
Screen Shot 2019-07-16 at 1.04.14 AM.png (115.3 KB) - added by garrett-eclipse 11 months ago.
Screen of updated verbiage on Plugins > Drop-in list view
Screen Shot 2019-07-16 at 1.04.37 AM.png (59.2 KB) - added by garrett-eclipse 11 months ago.
Updated string in Site Health > Info > Drop-ins
47247.2.diff (1.7 KB) - added by garrett-eclipse 11 months ago.
Updated to add commas for better reading.

Download all attachments as: .zip

Change History (16)

@ramiy
13 months ago

@ramiy
13 months ago

@ramiy
12 months ago

#1 @desrosj
11 months ago

  • Component changed from Plugins to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#2 @Clorith
11 months ago

I agree, different texts in various places here makes little sense.

What about something as follows, which merges the two together, so they can reliably be used in all locations:

Drop-ins are single files found in the wp-contentdirectory that replace or enhance WordPress features in ways that are not possible for traditional plugins.

@garrett-eclipse
11 months ago

patch to merge strings

@garrett-eclipse
11 months ago

Screen of updated verbiage on Plugins > Drop-in list view

@garrett-eclipse
11 months ago

Updated string in Site Health > Info > Drop-ins

#3 @garrett-eclipse
11 months ago

  • Keywords has-patch needs-testing added

Thanks for flagging this @ramiy and for the suggested text @Clorith I've uploaded 47247.diff to address this.

#4 @Clorith
11 months ago

Reading over it, it needs some commas to be easier to read (if this is the string we want to go with, mind you, I'd leave it for a day or two so others can voice in on this, since it also touches strings that have been in core for quite a while);

Drop-ins are single files, found in the wp-content directory, that replace or enhance WordPress features in ways that are not possible for traditional plugins.

@garrett-eclipse
11 months ago

Updated to add commas for better reading.

#5 @garrett-eclipse
11 months ago

  • Keywords dev-feedback needs-copy-review added

Thanks @Clorith https://core.trac.wordpress.org/attachment/ticket/47247/47247.2.diff adds in the commas.
Added needs-copy-review to get feedback from @marybaum and dev-feedback to flag the concern of the age of one of the strings updated.

Version 0, edited 11 months ago by garrett-eclipse (next)

#6 @SergeyBiryukov
11 months ago

  • Milestone changed from Awaiting Review to 5.3

#7 @ramiy
11 months ago

@Clorith @garrett-eclipse I like the new string.

#8 @Clorith
9 months ago

  • Keywords commit added; needs-testing dev-feedback needs-copy-review removed
  • Type changed from defect (bug) to enhancement

47247.2.diff looks good to go, there's been no mention of there being problems with this.

#9 @SergeyBiryukov
9 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45905:

Site Health: Merge two similar strings explaining what drop-in plugins are.

Props garrett-eclipse, ramiy, Clorith.
Fixes #47247.

Note: See TracTickets for help on using tickets.