WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 2 months ago

#47252 closed defect (bug) (fixed)

i18n: Merge similar translation strings - up to date

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-screenshots has-patch site-health commit
Focuses: administration Cc:

Description

See the screenshot with the strings that can be merged.

Attachments (4)

47252.png (140.9 KB) - added by ramiy 4 months ago.
47252.patch (1.7 KB) - added by ramiy 4 months ago.
47252.2.png (69.6 KB) - added by ramiy 4 months ago.
47252.3.png (48.1 KB) - added by ramiy 4 months ago.

Download all attachments as: .zip

Change History (12)

@ramiy
4 months ago

@ramiy
4 months ago

#1 @ramiy
4 months ago

  • Keywords has-patch site-health added

@ramiy
4 months ago

@ramiy
4 months ago

#2 @desrosj
3 months ago

  • Component changed from Administration to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#3 @ramiy
2 months ago

@desrosj @SergeyBiryukov can we address this in WordPress 5.3 ?

#4 @Clorith
2 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 5.3
  • Version set to 5.2

Yup, shouldn't be a problem to put this into 5.3, 47252.patch is simple enough to not be a problem.

#5 follow-up: @ramiy
2 months ago

On second thought, the text should be: All the plugins/themes/translations are up to date.

Saying Your plugins/themes/translations are all up to date. is problematic. I'm not sure about Your prefix.

Those are not my plugins. I didn't developed them. It can be my site but the plugins are not mine.

Also, not all the admin users are the site owners, saying Your... to those users is not accurate.

#6 in reply to: ↑ 5 ; follow-up: @SergeyBiryukov
2 months ago

Replying to ramiy:

Those are not my plugins. I didn't developed them. It can be my site but the plugins are not mine.

Perhaps, but we have quite a few other instances of "your plugins" or "your theme" in core, so changing that seems out of scope for this ticket. For now, let's go with 47252.patch.

#7 in reply to: ↑ 6 @ramiy
2 months ago

Replying to SergeyBiryukov:

Replying to ramiy:

Those are not my plugins. I didn't developed them. It can be my site but the plugins are not mine.

Perhaps, but we have quite a few other instances of "your plugins" or "your theme" in core, so changing that seems out of scope for this ticket. For now, let's go with 47252.patch.

I agree. Out of scope for this ticket. Let's merge the similar translation strings.

#8 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45647:

I18N: Merge duplicate "Your plugins/themes/translations are all up to date" strings.

Props ramiy.
Fixes #47252.

Note: See TracTickets for help on using tickets.