Opened 6 years ago
Closed 5 years ago
#47252 closed defect (bug) (fixed)
i18n: Merge similar translation strings - up to date
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.3 | Priority: | normal |
| Severity: | normal | Version: | 5.2 |
| Component: | Site Health | Keywords: | has-screenshots has-patch site-health commit |
| Focuses: | administration | Cc: |
Description
See the screenshot with the strings that can be merged.
Attachments (4)
Change History (12)
#4
@
5 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 5.3
- Version set to 5.2
Yup, shouldn't be a problem to put this into 5.3, 47252.patch is simple enough to not be a problem.
#5
follow-up:
↓ 6
@
5 years ago
On second thought, the text should be: All the plugins/themes/translations are up to date.
Saying Your plugins/themes/translations are all up to date. is problematic. I'm not sure about Your prefix.
Those are not my plugins. I didn't developed them. It can be my site but the plugins are not mine.
Also, not all the admin users are the site owners, saying Your... to those users is not accurate.
#6
in reply to:
↑ 5
;
follow-up:
↓ 7
@
5 years ago
Replying to ramiy:
Those are not my plugins. I didn't developed them. It can be my site but the plugins are not mine.
Perhaps, but we have quite a few other instances of "your plugins" or "your theme" in core, so changing that seems out of scope for this ticket. For now, let's go with 47252.patch.
#7
in reply to:
↑ 6
@
5 years ago
Replying to SergeyBiryukov:
Replying to ramiy:
Those are not my plugins. I didn't developed them. It can be my site but the plugins are not mine.
Perhaps, but we have quite a few other instances of "your plugins" or "your theme" in core, so changing that seems out of scope for this ticket. For now, let's go with 47252.patch.
I agree. Out of scope for this ticket. Let's merge the similar translation strings.
Moving Site Health tickets into their lovely new home, the Site Health component.