WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 4 years ago

#47259 closed defect (bug) (fixed)

i18n: Merge similar translation strings - tables

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch commit
Focuses: administration, ui-copy Cc:

Description

See the screenshot with the strings that can be merged.

Attachments (5)

47259a.png​ (106.9 KB) - added by ramiy 6 years ago.
47259b.png​ (80.7 KB) - added by ramiy 6 years ago.
47259c.png​ (13.6 KB) - added by ramiy 6 years ago.
47259.patch​ (867 bytes) - added by ramiy 6 years ago.
47259.2.patch​ (879 bytes) - added by justinahinon 4 years ago.
Initial patch is good, just refreshed it against trunk.

Download all attachments as: .zip

Change History (20)

@ramiy
6 years ago

@ramiy
6 years ago

@ramiy
6 years ago

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-screenshots has-patch added

#2 @desrosj
6 years ago

  • Milestone changed from Awaiting Review to 5.3

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
6 years ago

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
5 years ago

#5 @garrett-eclipse
5 years ago

  • Component changed from Editor to I18N
  • Focuses ui-copy added
  • Keywords needs-refresh added
  • Milestone changed from 5.3 to 5.4

@ramiy checking the patch it only addresses the Column(s) strings and none of the others shown in your screenshots for Table, etc.

I'm marking for refresh and moving into 5.4 as we're already in beta2 for 5.3

#6 @davidbaumwald
5 years ago

  • Milestone changed from 5.4 to Future Release

With 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to Future Release. If any maintainer or committer feels this should be included or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

#7 @ramiy
5 years ago

@garrett-eclipse

For more string changes see ​https://github.com/WordPress/gutenberg/pull/24169

This Trac ticket fixes strings in WordPress core, GitHub PR fixes Gutenberg strings.

#8 @ramiy
5 years ago

  • Keywords needs-refresh removed

This ticket was mentioned in ​Slack in #core-i18n by ramiy. ​View the logs.
5 years ago

#10 @ramiy
4 years ago

Ok, the Gutenberg PR merged. Only the attached patch left.

@SergeyBiryukov Please set the Milestone to 5.6.

#11 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 5.6

@justinahinon
4 years ago

Initial patch is good, just refreshed it against trunk.

This ticket was mentioned in ​Slack in #core by justinahinon. ​View the logs.
4 years ago

This ticket was mentioned in ​Slack in #core by justinahinon. ​View the logs.
4 years ago

#14 @audrasjb
4 years ago

  • Keywords commit added

The patch looks good to go.

Adding commit keyword, as per yesterday’s bug scrub.

#15 @SergeyBiryukov
4 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 49541:

I18N: Merge duplicate "Column" strings, remove unnecessary context.

Props ramiy, justinahinon, garrett-eclipse, audrasjb.
Fixes #47259.

Note: See TracTickets for help on using tickets.