WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 17 months ago

Last modified 16 months ago

#47264 closed defect (bug) (fixed)

Wrong singular string in class-wp-site-health.php

Reported by: edocev Owned by: SergeyBiryukov
Milestone: 5.2.1 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch site-health i18n-change
Focuses: administration Cc:

Description

Hello, there is wrong string for singular value in site health.
It is "Your site has %d installed theme, and they are all up to date" while it should be more like "Your site has %d installed theme, and it is up to date"

Fixed it with the patch attached.

Attachments (4)

class-wp-site-health.diff (125.3 KB) - added by edocev 18 months ago.
47264.diff (125.3 KB) - added by edocev 18 months ago.
Propper diff attached
47264.2.diff (145.8 KB) - added by edocev 18 months ago.
47264.3.diff (611 bytes) - added by Presskopp 18 months ago.

Download all attachments as: .zip

Change History (11)

@edocev
18 months ago

Propper diff attached

@edocev
18 months ago

@Presskopp
18 months ago

#1 @Presskopp
18 months ago

Hello and thank you! Please check that your patch looks like the attached one.

#2 @Presskopp
18 months ago

  • Severity changed from minor to normal
  • Summary changed from Wrong singular string in class-wp-site-helath.php to Wrong singular string in class-wp-site-health.php

#3 @SergeyBiryukov
18 months ago

  • Keywords site-health added
  • Milestone changed from Awaiting Review to 5.2.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
17 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45336:

Site Health: Use correct singular string for plugin and theme version tests.

Props edocev, Presskopp.
Fixes #47264.

#5 @SergeyBiryukov
17 months ago

In 45337:

Site Health: Use correct singular string for plugin and theme version tests.

Props edocev, Presskopp.
Merges [45336] to the 5.2 branch.
Fixes #47264.

#6 @ocean90
17 months ago

  • Keywords i18n-change added

#7 @spacedmonkey
16 months ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.