WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 8 weeks ago

#47271 closed defect (bug) (fixed)

i18n: Avoid using HTML tags in translation strings (wp-includes/customize/class-wp-customize-theme-control.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.3 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-screenshots has-patch
Focuses: administration Cc:

Description

See the attached patch.

Attachments (2)

47271.png (7.1 KB) - added by ramiy 2 months ago.
47271.patch (902 bytes) - added by ramiy 2 months ago.

Download all attachments as: .zip

Change History (5)

@ramiy
2 months ago

@ramiy
2 months ago

#1 @ramiy
2 months ago

  • Keywords has-screenshots has-patch added

Simpler string to translate in RTL languages where LTR code is making it hard to translate RTL letters.

The is an unwritten convention implemented all over the code. It should be implemented in this string too.

Also, in this case (<span>Previewing:</span> %s), translators can't really translate the HTML and the placeholder.

#2 @SergeyBiryukov
8 weeks ago

  • Milestone changed from Awaiting Review to 5.3

#3 @SergeyBiryukov
8 weeks ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 45435:

I18N: Remove unnecessary HTML from "Previewing:" string in WP_Customize_Theme_Control.

Props ramiy.
Fixes #47271.

Note: See TracTickets for help on using tickets.