WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 9 months ago

#47294 closed task (blessed) (fixed)

5.2.1 About Page Updates

Reported by: ianbelanger Owned by: desrosj
Milestone: 5.2.1 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit
Focuses: Cc:

Description

With 5.2.1-RC on its way, it's time to update the About page.

Attachments (3)

47294.diff (1.5 KB) - added by earnjam 9 months ago.
47294.2.diff (1.5 KB) - added by earnjam 9 months ago.
bug fixes only messaging
47294.3.diff (1.5 KB) - added by earnjam 9 months ago.

Download all attachments as: .zip

Change History (12)

#1 @desrosj
9 months ago

  • Component changed from General to Help/About

@earnjam
9 months ago

@earnjam
9 months ago

bug fixes only messaging

#2 follow-up: @SergeyBiryukov
9 months ago

Looking at 47294.2.diff, why the number passed to _n() is 14 if the number passed to printf() is 33?

Last edited 9 months ago by SergeyBiryukov (previous) (diff)

#3 in reply to: ↑ 2 @earnjam
9 months ago

Replying to SergeyBiryukov:

Looking at 47294.2.diff, why is the number passed to _n() is 14 if the number passed to printf() is 33?

Because I copied from a previous minor release's patch to keep the same format and wasn't paying close enough attention 😑 Thanks for catching that.

@earnjam
9 months ago

#4 follow-up: @birgire
9 months ago

This part sanitize_title( '5.2.1' ) in the latest patch - it seems unnecessary to sanitize a fixed string '5.2.1'

#5 @earnjam
9 months ago

Final bug fix count is actually going to be 32, instead of 33. Just waiting on #46937 to be committed for final total.

Last edited 9 months ago by earnjam (previous) (diff)

#6 @desrosj
9 months ago

  • Keywords has-patch added

This part sanitize_title( '5.2.1' ) in the latest patch - it seems unnecessary to sanitize a fixed string '5.2.1'

@birgire This replaces the .s with -, which is needed to link to the HelpHub correctly.

Also, to clarify the math behind that number (this always seems to get asked somewhere):

  • There will be 26 closed bugs in 5.2.1.
  • 7 bugs fixed in Gutenberg and were merged when the packages were bumped in #47284. But, 1 of those bugs was also reported in Trac (#47180), so 6.

Brings us to 32.

#7 in reply to: ↑ 4 @earnjam
9 months ago

Replying to birgire:

This part sanitize_title( '5.2.1' ) in the latest patch - it seems unnecessary to sanitize a fixed string '5.2.1'

Probably not needed, but was done that way with the last major security backport release a few months ago, so it's that away across a bunch of branches.

I think the intention is probably to make it easier to read and identify it as the actual version number, and then let sanitize_title() handle converting it to be used in the URL.

#8 @desrosj
9 months ago

  • Keywords commit added
  • Owner changed from ianbelanger to desrosj
  • Status changed from assigned to reviewing

#9 @desrosj
9 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45359:

Help/About: Update the about page for 5.2.1.

32 bugs were squashed in 5.2.1.

Props earnjam, ianbelanger, chanthaboune.
Fixes #47294.

Note: See TracTickets for help on using tickets.