Opened 4 years ago
Closed 4 years ago
#47294 closed task (blessed) (fixed)
5.2.1 About Page Updates
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.2.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Help/About | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
With 5.2.1-RC
on its way, it's time to update the About page.
Attachments (3)
Change History (12)
#2
follow-up:
↓ 3
@
4 years ago
Looking at 47294.2.diff, why is the number passed to _n()
is 14 if the number passed to printf()
is 33?
#3
in reply to:
↑ 2
@
4 years ago
Replying to SergeyBiryukov:
Looking at 47294.2.diff, why is the number passed to
_n()
is 14 if the number passed toprintf()
is 33?
Because I copied from a previous minor release's patch to keep the same format and wasn't paying close enough attention 😑 Thanks for catching that.
#4
follow-up:
↓ 7
@
4 years ago
This part sanitize_title( '5.2.1' )
in the latest patch - it seems unnecessary to sanitize a fixed string '5.2.1'
#5
@
4 years ago
Final bug fix count is actually going to be 32, instead of 33. Just waiting on #46937 to be committed for final total.
#6
@
4 years ago
- Keywords has-patch added
This part
sanitize_title( '5.2.1' )
in the latest patch - it seems unnecessary to sanitize a fixed string '5.2.1'
@birgire This replaces the .
s with -
, which is needed to link to the HelpHub correctly.
Also, to clarify the math behind that number (this always seems to get asked somewhere):
- There will be 26 closed bugs in 5.2.1.
- 7 bugs fixed in Gutenberg and were merged when the packages were bumped in #47284. But, 1 of those bugs was also reported in Trac (#47180), so 6.
Brings us to 32.
#7
in reply to:
↑ 4
@
4 years ago
Replying to birgire:
This part
sanitize_title( '5.2.1' )
in the latest patch - it seems unnecessary to sanitize a fixed string '5.2.1'
Probably not needed, but was done that way with the last major security backport release a few months ago, so it's that away across a bunch of branches.
I think the intention is probably to make it easier to read and identify it as the actual version number, and then let sanitize_title()
handle converting it to be used in the URL.
bug fixes only messaging