WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#47297 closed defect (bug) (fixed)

HTTP requests test in Site Health Status is not always correct

Reported by: chesio's profile chesio Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.2.1 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch site-health
Focuses: Cc:

Description

The test only checks whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, but should in addition check whether it also evaluates as true (see attached patch).

Attachments (2)

site-health-WP_HTTP_BLOCK_EXTERNAL.patch​ (624 bytes) - added by chesio 5 years ago.
site-health-WP_HTTP_BLOCK_EXTERNAL-min.patch​ (474 bytes) - added by chesio 5 years ago.
More concise patch

Download all attachments as: .zip

Change History (9)

@chesio
5 years ago

@chesio
5 years ago

More concise patch

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.2.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @SergeyBiryukov
5 years ago

  • Keywords site-health added

#3 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45328:

Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.

Props chesio.
Fixes #47297.

#4 @SergeyBiryukov
5 years ago

In 45329:

Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.

Props chesio.
Merges [45328] to the 5.2 branch.
Fixes #47297.

#5 @SergeyBiryukov
5 years ago

In 45330:

Site Health: Update mergeinfo for [45329].

See #47297.

This ticket was mentioned in ​Slack in #hosting-community by jadonn. ​View the logs.
5 years ago

#7 @spacedmonkey
5 years ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.