WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

Last modified 3 months ago

#47297 closed defect (bug) (fixed)

HTTP requests test in Site Health Status is not always correct

Reported by: chesio Owned by: SergeyBiryukov
Milestone: 5.2.1 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: has-patch site-health
Focuses: Cc:

Description

The test only checks whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, but should in addition check whether it also evaluates as true (see attached patch).

Attachments (2)

site-health-WP_HTTP_BLOCK_EXTERNAL.patch (624 bytes) - added by chesio 4 months ago.
site-health-WP_HTTP_BLOCK_EXTERNAL-min.patch (474 bytes) - added by chesio 4 months ago.
More concise patch

Download all attachments as: .zip

Change History (9)

@chesio
4 months ago

More concise patch

#1 @SergeyBiryukov
4 months ago

  • Milestone changed from Awaiting Review to 5.2.1
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @SergeyBiryukov
4 months ago

  • Keywords site-health added

#3 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 45328:

Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.

Props chesio.
Fixes #47297.

#4 @SergeyBiryukov
4 months ago

In 45329:

Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.

Props chesio.
Merges [45328] to the 5.2 branch.
Fixes #47297.

#5 @SergeyBiryukov
4 months ago

In 45330:

Site Health: Update mergeinfo for [45329].

See #47297.

This ticket was mentioned in Slack in #hosting-community by jadonn. View the logs.


4 months ago

#7 @spacedmonkey
3 months ago

  • Component changed from Administration to Site Health
Note: See TracTickets for help on using tickets.