WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#47297 closed defect (bug) (fixed)

HTTP requests test in Site Health Status is not always correct

Reported by: chesio Owned by: SergeyBiryukov
Priority: normal Milestone: 5.2.1
Component: Site Health Version: 5.2
Severity: normal Keywords: has-patch site-health
Cc: Focuses:

Description

The test only checks whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, but should in addition check whether it also evaluates as true (see attached patch).

Attachments (2)

site-health-WP_HTTP_BLOCK_EXTERNAL.patch​ (624 bytes ) - added by chesio 7 years ago.
site-health-WP_HTTP_BLOCK_EXTERNAL-min.patch​ (474 bytes ) - added by chesio 7 years ago.
More concise patch

Download all attachments as: .zip

Change History (9)

@chesio
7 years ago

@chesio
7 years ago

More concise patch

#1 @SergeyBiryukov
7 years ago

  • Milestone Awaiting Review → 5.2.1
  • Owner set to SergeyBiryukov
  • Status new → reviewing

#2 @SergeyBiryukov
7 years ago

  • Keywords site-health added

#3 @SergeyBiryukov
7 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 45328:

Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.

Props chesio.
Fixes #47297.

#4 @SergeyBiryukov
7 years ago

In 45329:

Site Health: In HTTP requests test, when checking whether the WP_HTTP_BLOCK_EXTERNAL constant is defined, check its value as well.

Props chesio.
Merges [45328] to the 5.2 branch.
Fixes #47297.

#5 @SergeyBiryukov
7 years ago

In 45330:

Site Health: Update mergeinfo for [45329].

See #47297.

This ticket was mentioned in ​Slack in #hosting-community by jadonn. ​View the logs.
7 years ago

#7 @spacedmonkey
7 years ago

  • Component Administration → Site Health
Note: See TracTickets for help on using tickets.