Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#47298 closed enhancement (fixed)

Site Health: Use consistent capitalization in h3 headings

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: desrosj's profile desrosj
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health has-patch commit
Focuses: Cc:

Description

In Site Health <h3> headings, only the first words are capitalized, which looks weird to me and doesn't seem to follow any existing pattern in core:

%s Critical issues
%s Recommended improvements
%s Items with no issues detected

They should either be consistently capitalized:

%s Critical Issues
%s Recommended Improvements
%s Items with No Issues Detected

or lowercased:

%s critical issues
%s recommended improvements
%s items with no issues detected

Attachments (5)

update-changes.patch (2.7 KB) - added by ajayghaghretiya1 5 years ago.
update the capitalized text.
47298.diff (1.4 KB) - added by ronakganatra 5 years ago.
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
47298-1.diff (1.4 KB) - added by ronakganatra 5 years ago.
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
47298-js.diff (1.3 KB) - added by ronakganatra 5 years ago.
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
47298.2.diff (2.8 KB) - added by mukesh27 5 years ago.
Updated patch.

Download all attachments as: .zip

Change History (14)

#1 @ajayghaghretiya1
5 years ago

As using the capitalized the title like "Site Health Status" then we should use the capitalized in the h3 as well.

Attached the changes.

Thanks.

@ajayghaghretiya1
5 years ago

update the capitalized text.

@ronakganatra
5 years ago

I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"

@ronakganatra
5 years ago

I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"

@ronakganatra
5 years ago

I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"

#2 @ronakganatra
5 years ago

  • Keywords has-patch added
  • Type changed from defect (bug) to enhancement
  • Version set to 5.2

Ignore 47298-1.diff

#3 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.3

#4 @mukesh27
5 years ago

Agreed with @ronakganatra. We have to use lowercase.

On small change in 47298-js.diff patch that i have fixed in new patch.

heading = sprintf( _n( '%s Critical issue', '%s critical issues', count ), '<span class="issue-count">' + count + '</span>' );

@mukesh27
5 years ago

Updated patch.

#5 @desrosj
5 years ago

  • Component changed from Administration to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#6 @Clorith
5 years ago

  • Keywords commit added

I'm all for 47298.2.diff, and looking at the discussion at https://github.com/WordPress/gutenberg/issues/16764 it seems sentence case is more favorable in general, and sees Gutenberg move into it as well.

#7 @desrosj
5 years ago

  • Owner set to desrosj
  • Status changed from new to reviewing

#8 @desrosj
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 46199:

Site Health: Use sentence casing consistently in header tags.

Props SergeyBiryukov, ajayghaghretiya1, ronakganatra, mukesh27, Clorith.
Fixes #47298.

#9 in reply to: ↑ description @SergeyBiryukov
5 years ago

Replying to SergeyBiryukov:

In Site Health <h3> headings, only the first words are capitalized, which looks weird to me and doesn't seem to follow any existing pattern in core

Just noticed that's actually also the case in "At a Glance" dashboard widget:

%s Posts
%s Pages
%s Comments
%s Comments in moderation

Not going to address that now, though, maybe later :)

Note: See TracTickets for help on using tickets.