#47298 closed enhancement (fixed)
Site Health: Use consistent capitalization in h3 headings
Reported by: | SergeyBiryukov | Owned by: | desrosj |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | 5.2 |
Component: | Site Health | Keywords: | site-health has-patch commit |
Focuses: | Cc: |
Description
In Site Health <h3>
headings, only the first words are capitalized, which looks weird to me and doesn't seem to follow any existing pattern in core:
%s Critical issues %s Recommended improvements %s Items with no issues detected
They should either be consistently capitalized:
%s Critical Issues %s Recommended Improvements %s Items with No Issues Detected
or lowercased:
%s critical issues %s recommended improvements %s items with no issues detected
Attachments (5)
Change History (14)
@
5 years ago
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
@
5 years ago
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
@
5 years ago
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
#2
@
5 years ago
- Keywords has-patch added
- Type changed from defect (bug) to enhancement
- Version set to 5.2
Ignore 47298-1.diff
#4
@
5 years ago
Agreed with @ronakganatra. We have to use lowercase.
On small change in 47298-js.diff patch that i have fixed in new patch.
heading = sprintf( _n( '%s Critical issue', '%s critical issues', count ), '<span class="issue-count">' + count + '</span>' );
#5
@
5 years ago
- Component changed from Administration to Site Health
Moving Site Health tickets into their lovely new home, the Site Health component.
#6
@
5 years ago
- Keywords commit added
I'm all for 47298.2.diff, and looking at the discussion at https://github.com/WordPress/gutenberg/issues/16764 it seems sentence case is more favorable in general, and sees Gutenberg move into it as well.
#9
in reply to:
↑ description
@
5 years ago
Replying to SergeyBiryukov:
In Site Health
<h3>
headings, only the first words are capitalized, which looks weird to me and doesn't seem to follow any existing pattern in core
Just noticed that's actually also the case in "At a Glance" dashboard widget:
%s Posts %s Pages %s Comments %s Comments in moderation
Not going to address that now, though, maybe later :)
As using the capitalized the title like "Site Health Status" then we should use the capitalized in the h3 as well.
Attached the changes.
Thanks.