WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 2 months ago

#47298 new enhancement

Site Health: Use consistent capitalization in h3 headings

Reported by: SergeyBiryukov Owned by:
Milestone: 5.3 Priority: normal
Severity: normal Version: 5.2
Component: Site Health Keywords: site-health has-patch
Focuses: Cc:

Description

In Site Health <h3> headings, only the first words are capitalized, which looks weird to me and doesn't seem to follow any existing pattern in core:

%s Critical issues
%s Recommended improvements
%s Items with no issues detected

They should either be consistently capitalized:

%s Critical Issues
%s Recommended Improvements
%s Items with No Issues Detected

or lowercased:

%s critical issues
%s recommended improvements
%s items with no issues detected

Attachments (5)

update-changes.patch (2.7 KB) - added by ajayghaghretiya1 3 months ago.
update the capitalized text.
47298.diff (1.4 KB) - added by ronakganatra 3 months ago.
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
47298-1.diff (1.4 KB) - added by ronakganatra 3 months ago.
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
47298-js.diff (1.3 KB) - added by ronakganatra 3 months ago.
I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"
47298.2.diff (2.8 KB) - added by mukesh27 3 months ago.
Updated patch.

Download all attachments as: .zip

Change History (10)

#1 @ajayghaghretiya1
3 months ago

As using the capitalized the title like "Site Health Status" then we should use the capitalized in the h3 as well.

Attached the changes.

Thanks.

@ajayghaghretiya1
3 months ago

update the capitalized text.

@ronakganatra
3 months ago

I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"

@ronakganatra
3 months ago

I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"

@ronakganatra
3 months ago

I think all the small letter would be great because camel case would not look better like it is "item with no issues detected" but if we go to first letter capital on each then it should be like "Item With No Issues Detected"

#2 @ronakganatra
3 months ago

  • Keywords has-patch added
  • Type changed from defect (bug) to enhancement
  • Version set to 5.2

Ignore 47298-1.diff

#3 @SergeyBiryukov
3 months ago

  • Milestone changed from Awaiting Review to 5.3

#4 @mukesh27
3 months ago

Agreed with @ronakganatra. We have to use lowercase.

On small change in 47298-js.diff patch that i have fixed in new patch.

heading = sprintf( _n( '%s Critical issue', '%s critical issues', count ), '<span class="issue-count">' + count + '</span>' );

@mukesh27
3 months ago

Updated patch.

#5 @desrosj
2 months ago

  • Component changed from Administration to Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

Note: See TracTickets for help on using tickets.