Context Navigation

← Previous Ticket
Next Ticket →

#47299 closed enhancement (fixed)

Site Health: get_test_theme_version() + WP_DEFAULT_THEME = use get_core_default_theme() !

Reported by:	juliobox	Owned by:	SergeyBiryukov
Priority:	normal	Milestone:	5.3
Component:	Site Health	Version:	5.2
Severity:	minor	Keywords:	2nd-opinion site-health has-patch
Cc:		Focuses:

Description

Hello there

The test for get_test_theme_version() is checking if WP_DEFAULT_THEME is set to one of our installed theme. If not, the SH will tell us to use one.
But since I have a twentystuff theme on my installation, WordPress will find a fallback. Thanks to get_core_default_theme()!

We should also use this as a check.
I just did this:

<?php
if ( ! $has_default_theme ) {

becomes:

<?php
if ( ! $has_default_theme && ! WP_Theme::get_core_default_theme() ) {

That does the correct test I guess.

Thank you!

Attachments (1)

class-wp-site-health.php.patch (571 bytes ) - added by ajayghaghretiya1 7 years ago.: updated the file with the patch, Also check class exist.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
7 years ago

Keywords site-health added

#2 @SergeyBiryukov
7 years ago

Keywords dev-feedback removed
Milestone Awaiting Review → 5.3

Makes sense to me, populate_options() and validate_current_theme() do the same.

@ajayghaghretiya1
7 years ago

Attachment class-wp-site-health.php.patch added

updated the file with the patch, Also check class exist.

#3 @audrasjb
7 years ago

Keywords has-patch added; needs-patch removed

#4 @desrosj
7 years ago

Component Administration → Site Health

Moving Site Health tickets into their lovely new home, the Site Health component.

#5 @SergeyBiryukov
7 years ago

Owner set to SergeyBiryukov
Status new → reviewing

#6 @SergeyBiryukov
7 years ago

Resolution → fixed
Status reviewing → closed

In 45732:

Site Health: If WP_DEFAULT_THEME doesn't exist, use WP_Theme::get_core_default_theme() as a fallback.

Props ajayghaghretiya1, juliobox, SergeyBiryukov.
Fixes #47299.

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#47299 closed enhancement (fixed)

Site Health: get_test_theme_version() + WP_DEFAULT_THEME = use get_core_default_theme() !

Description

Attachments (1)

Change History (7)

#1 @SergeyBiryukov 7 years ago

#2 @SergeyBiryukov 7 years ago

@ajayghaghretiya1 7 years ago

#3 @audrasjb 7 years ago

#4 @desrosj 7 years ago

#5 @SergeyBiryukov 7 years ago

#6 @SergeyBiryukov 7 years ago